New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add reader for hamamatsu .img format #87
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #87 +/- ##
==========================================
+ Coverage 83.75% 83.94% +0.18%
==========================================
Files 74 76 +2
Lines 9800 10132 +332
Branches 2163 2210 +47
==========================================
+ Hits 8208 8505 +297
- Misses 1097 1114 +17
- Partials 495 513 +18
☔ View full report in Codecov by Sentry. |
b1eb88d
to
8a1c6e0
Compare
dc91b68
to
b3a8db4
Compare
@Attolight-NTappy and @gkusch - I know you are happy using the tiff import of Hamamatsu Streak images, but maybe you could also have a look at this reader for the Hamamatsu format? |
I will try to export a Streak in the Format next time I am at the microscope and compare with .tiff Currently measurements done with the Attolight Software controlling the Streak will be autosaved as .tiff so not super relevant for us in general. Are there any inherent advantages of this format vs tif or is it more a matter of providing choice? |
According to the Hamamatsu specs, Both readers do read in the But I'm curious what your comparison would give. |
While reproducing plots, I discovered some problems. I didn't put much thought into reading the data block, because I thought it was just a block of continuous data. Hopefully, changing the endianness fixes the problem. But the plot still slightly differs compared to the original from a matlab script (which performs multiple steps). I will further check this and try to reproduce it exactly. |
e5f34f9
to
479bd1d
Compare
hamamatsu also uses .img extension
The problem is fixed now. |
Indeed, the data looks good now. I compared a real dataset for which I have both the |
We should include this format documentation in the documentation under |
@@ -0,0 +1,21 @@ | |||
.. _hamamatsu-format: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add to index.rst
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is added in docs/supported_formats/index.rst
.
---------- | ||
%s | ||
%s | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add use_uniform_signal_axis
parameter, e.g. by copying the docstring from jobin-yvon (or by adding it to _docstrings
)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I copied it for now and will do a follow up PR, where I add this to _docstrings and move the signal axis fit to utils.
Add support for reading Hamamatsu's .img file format.
Progress of the PR
upcoming_changes
folder (seeupcoming_changes/README.rst
),readthedocs
doc build of this PR (link in github checks)Minimal example of the bug fix or the new feature