Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rails generator and react import misleading #347

Closed
catmando opened this issue Feb 11, 2021 · 0 comments
Closed

rails generator and react import misleading #347

catmando opened this issue Feb 11, 2021 · 0 comments
Labels
compatibility compatibility with dependencies such as Rails, Opal, React, etc. NOT FUNCTIONAL COMPATIBILITY ready-to-release Internal Use Only: Has been fixed, specs passing and pushed to edge branch
Projects
ALPHA to production

Comments

@catmando
Copy link
Contributor

Rails generator leaves this line in hyperstack.rb

Hyperstack.cancel_import 'react/react-source-browser' # bring your own React and ReactRouter via Yarn/Webpacker

This is misleading. Latest Hyperstack does not import react/react-source-browser, so commenting this out, does nothing.

Instead this should read:

# Hyperstack.import 'react/react-source-browser' # uncomment this line if you want hyperstack to bring its copy of react
@catmando catmando added this to To do in ALPHA to production via automation Feb 11, 2021
@catmando catmando added compatibility compatibility with dependencies such as Rails, Opal, React, etc. NOT FUNCTIONAL COMPATIBILITY needs doc Everything is working, but documentation is needed. labels Feb 11, 2021
ALPHA to production automation moved this from To do to Done Mar 14, 2021
@catmando catmando added ready-to-release Internal Use Only: Has been fixed, specs passing and pushed to edge branch and removed needs doc Everything is working, but documentation is needed. labels Mar 15, 2021
@catmando catmando reopened this Mar 15, 2021
ALPHA to production automation moved this from Done to In progress Mar 15, 2021
ALPHA to production automation moved this from In progress to Done Mar 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
compatibility compatibility with dependencies such as Rails, Opal, React, etc. NOT FUNCTIONAL COMPATIBILITY ready-to-release Internal Use Only: Has been fixed, specs passing and pushed to edge branch
Projects
ALPHA to production
  
Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@catmando