Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

count of scope is unnecessarily replaced with a dummy "1" #79

Closed
catmando opened this issue Dec 6, 2018 · 1 comment
Closed

count of scope is unnecessarily replaced with a dummy "1" #79

catmando opened this issue Dec 6, 2018 · 1 comment
Labels
bug Something isn't working ready-to-release Internal Use Only: Has been fixed, specs passing and pushed to edge branch
Milestone

Comments

@catmando
Copy link
Contributor

catmando commented Dec 6, 2018

get the count of a scope (without any records)
then later get some data for the same scope
the count will go to "1", then come back at the correct value.

I assume that when we fetch the actual scope data, we ignore the fact that we already know the count, and so we replace the actual known count with a dummy value.

It works out in the end, but causes a brief flicker on the display.

@catmando catmando added the bug Something isn't working label Dec 6, 2018
@catmando catmando added this to the alpha1.3 milestone Dec 7, 2018
@catmando
Copy link
Contributor Author

closed. for example see: batch4/scope_spec.rb it "will not use a dummy count if the count is already known"

@catmando catmando reopened this Jan 15, 2019
@catmando catmando added the ready-to-release Internal Use Only: Has been fixed, specs passing and pushed to edge branch label Jan 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ready-to-release Internal Use Only: Has been fixed, specs passing and pushed to edge branch
Projects
None yet
Development

No branches or pull requests

1 participant