Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename triggers to fires #91

Closed
catmando opened this issue Dec 12, 2018 · 2 comments
Closed

rename triggers to fires #91

catmando opened this issue Dec 12, 2018 · 2 comments
Labels
enhancement New feature or request ready-to-release Internal Use Only: Has been fixed, specs passing and pushed to edge branch
Milestone

Comments

@catmando
Copy link
Contributor

its shorter, sounds better, and has same length as param so lines up nicely in declarations

@catmando catmando added this to the alpha1.3 milestone Dec 12, 2018
@catmando catmando added the enhancement New feature or request label Dec 12, 2018
@catmando catmando added the ready-to-release Internal Use Only: Has been fixed, specs passing and pushed to edge branch label Jan 15, 2019
@catmando
Copy link
Contributor Author

this has been closed since initial commit to this branch

@catmando
Copy link
Contributor Author

example:

class EditItem < HyperComponent
  param :todo
  other :others

  fires :save
  fires :cancel

  PLACE_HOLDER = 'What is left to do today?'

  render      { INPUT(others, placeholder: PLACE_HOLDER, defaultValue: todo.title) }

  on(:enter)  { |evt| todo.update(title: evt.target.value) && save! }
  on(:blur)   { cancel! }

  after_mount { jQ[dom_node].focus }
end

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request ready-to-release Internal Use Only: Has been fixed, specs passing and pushed to edge branch
Projects
None yet
Development

No branches or pull requests

1 participant