Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thanks #25

Closed
Robinlovelace opened this issue Apr 16, 2020 · 3 comments
Closed

Thanks #25

Robinlovelace opened this issue Apr 16, 2020 · 3 comments

Comments

@Robinlovelace
Copy link

Hi guys, just wanted to say, huge thanks for this package: it's saved me a huge amount of programming and computer time! This is a godsend for work-in-progress updates to cyclestreets, an interface to routing service for cyclists by cyclists by @mvl22 & co:

  dist_list = lapply(coord_list, function(x) {
    geodist::geodist(
      data.frame(x = x[, 1], y = x[, 2]),
      sequential = TRUE
      )}
    )
@mpadge
Copy link
Member

mpadge commented Apr 16, 2020

Aw shucks, thanks! Maybe just worth noting that it does not do any intelligent checking for the default measure = "cheap", and this can be very divergent beyond about 100km. So worth doing a post-check on results to get max dist, and if too large, explicitly specify alternative measure. Which makes me realise that should be rectified, so i'll open a new issue to put a post-check on, and issue warning for when cheapdist might become inaccurate.

@Robinlovelace
Copy link
Author

Average segment distances are ~20m so should be fine. Plus can compare with actual distances, although those are less accurate, in m. Closing for now!

@mdsumner
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants