Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make EncoderJNI and EncoderJNI.Wrapper public? #123

Closed
deshanxiao opened this issue Dec 27, 2023 · 1 comment · Fixed by #124
Closed

Make EncoderJNI and EncoderJNI.Wrapper public? #123

deshanxiao opened this issue Dec 27, 2023 · 1 comment · Fixed by #124
Labels
enhancement New feature or request

Comments

@deshanxiao
Copy link
Contributor

deshanxiao commented Dec 27, 2023 •
edited
Loading

Hello, I notice that DecoderJNI and DecoderJNI.Wrapper are marked as public class. Is it possible to mark EncoderJNI and EncoderJNI.Wrapper as public too?

This requirement comes from the fact that we want to support brotli codec in Apache ORC. However, Bytebuffer overflow needs to be considered in ORC, and frequent copies are not very friendly to performance. We want to use EncoderJNI directly to support these special scenario.
@hyperxpro
Copy link
Owner

Sure, feel free to do a PR.

@hyperxpro hyperxpro added the enhancement New feature or request label Dec 27, 2023
@deshanxiao deshanxiao mentioned this issue Dec 28, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make EncoderJNI and EncoderJNI.Wrapper public deshanxiao/Brotli4j
2 participants
@hyperxpro @deshanxiao