Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accessibility Issues with DateInput #415

Closed
nikeeshi opened this issue Oct 13, 2020 · 1 comment
Closed

Accessibility Issues with DateInput #415

nikeeshi opened this issue Oct 13, 2020 · 1 comment

Comments

@nikeeshi
Copy link
Contributor

nikeeshi commented Oct 13, 2020 •
edited

Subject of the issue

DateInput does not follow WCAG.

[BUG] Bug Reproduce Steps

  1. Install Axe.
    https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd
  2. Run the test in the demo page. https://hypeserver.github.io/react-date-range/
    Instead of this step, you can also run yarn start locally in this repository.
  3. Axe reports issues of DateInput that "Form elements must have labels".

[BUG] Expected behaviour

No issue should be reported.

The react-date-range picker should include in their API a way to set a aria-label to these DateInput

Environment

Package Version: 1.0.3 and the current demo version.
React version: -
Node version: -
Browser: Chrome 85
image
@nikeeshi nikeeshi mentioned this issue Oct 15, 2020
Merged
3 tasks
@kamyar
Copy link
Contributor

kamyar commented Jun 10, 2021

Should be fixed please feel free to open a new issue if something is missing

@kamyar kamyar closed this as completed Jun 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kamyar @nikeeshi