Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-accept remote Deletes #162

Open
fauno opened this issue Apr 15, 2024 · 3 comments
Open

Auto-accept remote Deletes #162

fauno opened this issue Apr 15, 2024 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@fauno
Copy link
Collaborator

fauno commented Apr 15, 2024

On distributed-press-api-client I hardcoded a 1MiB limit to responses to prevent being zip bombed and today the response for @sutty@sutty.nl inbox was failing because it contains 4608 Delete activities xD

I think SI should:

  • Auto-accept remote Deletes
  • Send an onapprove hook so the CMS can delete locally

Related #159 #163

@fauno fauno added the enhancement New feature or request label Apr 15, 2024
@fauno
Copy link
Collaborator Author

fauno commented Apr 16, 2024

Note: The 1MiB hard-limit came from Mastodon

@RangerMauve RangerMauve transferred this issue from hyphacoop/social.distributed.press May 2, 2024
@sutty-coop sutty-coop assigned sutty-coop and unassigned RangerMauve Jun 3, 2024
@sutty-coop
Copy link
Collaborator

@fauno debería pasarle la información a Agus para que pueda abordar este issue

@sutty-coop
Copy link
Collaborator

sutty-coop commented Jul 15, 2024

I checked with Agus on July 11th and they said this is pending. I'll update estimated completion date by end of July.

CHANGES: Mauve mentions that we ignore deletes related to Actors we've been before. This helps avoid SPAM from Mastodon

TO-DO:

  • respect the delete to remove notes from deleted users and for deleted activities

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: In Progress
Development

No branches or pull requests

4 participants