Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make is a Dependency but the docs don't state this #62

Closed
willhayslett opened this issue Oct 25, 2018 · 2 comments
Closed

Make is a Dependency but the docs don't state this #62

willhayslett opened this issue Oct 25, 2018 · 2 comments

Comments

@willhayslett
Copy link

Hi,

Just a small issue. The docs state:

To use the plugin, you do not need any special dependencies.

The semantics of "special" may be debated here, but we encountered errors installing this plugin in an Ubuntu image because it did not make. It may help to list out in the docs that you do actually need the make utility.

Thanks!

@hypnoglow
Copy link
Owner

Hi,

Nice catch, thanks! make is a dependency indeed. However, we can avoid this dependency and configure plugin.yaml file just to execute ./hack/install.sh directly. What do you think?

@willhayslett
Copy link
Author

I think that makes sense. PR sent for the changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants