New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bug] Highlighting only keeps the most recent highlight #53
Comments
This sometimes happens to me as well, although steps to reproduce it are not exactly the same as described by @matwilso. |
I have also noticed that this happens not just in the Chrome browser extension, but also in the Firefox bookmarklet, so it seems to be a more general problem with Hypothesis. |
@matwilso and @diegodlh we've tried to reproduce the issues you're seeing but haven't been able to successfully reproduce this highlight behavior. Is it possible for you to share a screenshot or capture a video of what you're seeing? That would be very helpful for us in troubleshooting this bug. I have a hunch that this is one of those more difficult to identify bugs. |
Thanks @ajpeddakotla for answering. I have the same hunch. This happens to me quite often, but I'm afraid I don't know how to force it to happen. I have no experience debugging browser extensions. Is there a way I could output verbose information to the browser's console? Or, even better, dump it to some file? So, whenever this happens to me, I have something more informative to analyze and send you. I can send you a video as you suggested, if not, but I think that's way less useful. Thanks! |
Here I found a way to reproduce a bug that, not exactly what described in my previous message, can be related to it. |
Here is a screen capture of the behavior I described: (also, the mouse is not shown in the video, but I always click on the Highlight option) |
Here I attach a recording the behavior described in my message from Aug 24. I was reading and annotating a webpage and at some point t in time (I would say I did nothing in particular, although I can't be 100% sure) highlights would no longer be saved and new ones override immediately previous ones. If I reloaded the page (not shown) all highlights made after time t would be lost. In this video I show how clicking on the last highlight opens the side bar, makes the highlight be saved correctly, and resumes proper behavior. |
Another user has reported this issue in Zendesk. He provides a gif and this link: http://drnissani.net/mnissani/RevolutionarysToolkit/TheMoonIsAHarshMistress.pdf Potentially of note:
|
I am now unable to reproduce this at any of the URLs mentioned here. I even tried leaving the tab open in the background for ~30mins and coming back to it. |
closing for now - will re-open if we see this come up again |
Version: Hypothesis Chrome extension 1.40.0.0
Steps to repro
I have found this behavior happens after I "Highlight" something, then click on it again and edit the contents in the sidebar to add an annotation. So adding an annotation to a Highlight. Then trying to highlight new text leads to this problem.
Expected behavior
Highlighting some text on a website and clicking "Highlight" should color the text and should not affect previous highlights.
Observed behavior
Only one new highlight is allowed at a time. Highlighting new text overrides the previous highlight.
Other notes
Refreshing the page fixes it and causes the expected behavior again, but only saves the most recent highlight from before the refresh. (The overriding bug is persistent, ie. not just a display error).
The text was updated successfully, but these errors were encountered: