Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] Highlighting only keeps the most recent highlight #53

Closed
matwilso opened this issue Sep 20, 2017 · 10 comments
Closed

[bug] Highlighting only keeps the most recent highlight #53

matwilso opened this issue Sep 20, 2017 · 10 comments

Comments

@matwilso
Copy link

Version: Hypothesis Chrome extension 1.40.0.0

Steps to repro
I have found this behavior happens after I "Highlight" something, then click on it again and edit the contents in the sidebar to add an annotation. So adding an annotation to a Highlight. Then trying to highlight new text leads to this problem.

Expected behavior
Highlighting some text on a website and clicking "Highlight" should color the text and should not affect previous highlights.

Observed behavior
Only one new highlight is allowed at a time. Highlighting new text overrides the previous highlight.

alt

Other notes

Refreshing the page fixes it and causes the expected behavior again, but only saves the most recent highlight from before the refresh. (The overriding bug is persistent, ie. not just a display error).

@matwilso matwilso changed the title Highlighting only keeps the most recent highlight [bug] Highlighting only keeps the most recent highlight Sep 20, 2017
@diegodlh
Copy link

This sometimes happens to me as well, although steps to reproduce it are not exactly the same as described by @matwilso.
In my case, everything is working OK until at some moment (apparently random) new highlights override the immediate previous one (as opposed to original description, I don't need to "add an annotation to the [previous] highlight" for this to happen).
If I reload the webpage, it usually starts working OK again, but highlights made after the extension began to malfunction are lost.
Another way that seems to fix it is clicking on the highlight so that it appears in the side bar. As if this step was needed to reconnect with the server to start saving highlights again.
This is bug is very frustrating because it usually happens that you don't see your previous highlights when making new ones. So you don't notice they are disappearing. Until you make a highlight next to another, and then it's too late (you've lost a lot already).
The behaviour is very similar to what happens when you try to make a highlight without logging in (highlight isn't saved and no warning is displayed). Maybe this can give us a clue of why this is happening.
Maybe a warning should be shown when the highlight or annotation couldn't be saved successfully (either because of this bug or because one is no longer logged in -and in my case it happens very often that I get logged out for some reason); so the user can tell if he/she can continue highlighting, or has to do something (log in or refresh webpage) before proceeding.

@matwilso
Copy link
Author

I have also noticed that this happens not just in the Chrome browser extension, but also in the Firefox bookmarklet, so it seems to be a more general problem with Hypothesis.

@ajpeddakotla
Copy link

@matwilso and @diegodlh we've tried to reproduce the issues you're seeing but haven't been able to successfully reproduce this highlight behavior.

Is it possible for you to share a screenshot or capture a video of what you're seeing? That would be very helpful for us in troubleshooting this bug. I have a hunch that this is one of those more difficult to identify bugs.

@diegodlh
Copy link

Thanks @ajpeddakotla for answering. I have the same hunch. This happens to me quite often, but I'm afraid I don't know how to force it to happen. I have no experience debugging browser extensions. Is there a way I could output verbose information to the browser's console? Or, even better, dump it to some file? So, whenever this happens to me, I have something more informative to analyze and send you. I can send you a video as you suggested, if not, but I think that's way less useful. Thanks!

@diegodlh
Copy link

Here I found a way to reproduce a bug that, not exactly what described in my previous message, can be related to it.
If I select text, then activate the hypothes.is extension, and shortly after choose to highlight the text selected, then the annotation does not appear in the side bar, and is lost if page is reloaded.
As opposed to what I described before, in this case new higlights don't make the previous unsaved one disappear.
I found that it seems to be related to how shortly after activating the extension I do the highlight. See later in the video that if I wait until the previously saved highlights are loaded, then the new one is saved correctly.
Again, this is not the exact same behavior as previously described, but I feel it might be related.
I attach as well a video showing what happens when trying to highlight without being logged-in. This is more similar to what I reported in my previous message.
screen_record.zip

@matwilso
Copy link
Author

matwilso commented Aug 31, 2018

Here is a screen capture of the behavior I described:
https://pubweb.eng.utah.edu/~matwilso/media/hypo-bug.mp4

(also, the mouse is not shown in the video, but I always click on the Highlight option)

@diegodlh
Copy link

Here I attach a recording the behavior described in my message from Aug 24. I was reading and annotating a webpage and at some point t in time (I would say I did nothing in particular, although I can't be 100% sure) highlights would no longer be saved and new ones override immediately previous ones. If I reloaded the page (not shown) all highlights made after time t would be lost. In this video I show how clicking on the last highlight opens the side bar, makes the highlight be saved correctly, and resumes proper behavior.
Kazam_screencast_00002.mp4.zip

@klemay
Copy link
Contributor

klemay commented Nov 28, 2018

Another user has reported this issue in Zendesk. He provides a gif and this link: http://drnissani.net/mnissani/RevolutionarysToolkit/TheMoonIsAHarshMistress.pdf

Potentially of note:

It usually happens after I left the page open too long. The issue goes away when I refresh the page.

@klemay
Copy link
Contributor

klemay commented Nov 9, 2020

I am now unable to reproduce this at any of the URLs mentioned here. I even tried leaving the tab open in the background for ~30mins and coming back to it.

@klemay
Copy link
Contributor

klemay commented Nov 9, 2020

closing for now - will re-open if we see this come up again

@klemay klemay closed this as completed Nov 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants