Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

when user a annotates, user b's in-progress annotation is destroyed #92

Closed
judell opened this issue Sep 9, 2016 · 8 comments
Closed

Comments

@judell
Copy link
Contributor

judell commented Sep 9, 2016

Screencast

http://jonudell.net/h/browser-a-kills-in-progress-annotation-in-browser-b.mp4

Setup:

Behavior:

  • judell has an annotation in progress
  • jonudell creates an annotation
  • judell's in-progress annotation is destroyed.
@robertknight
Copy link
Member

robertknight commented Sep 9, 2016

@judell - It is difficult to see exactly what is going on because that page has a large number of annotations. Unless it is crucial to reproducing or understanding the issue, it is much easier to see what is happening if you have the simplest possible test case.

Can you also confirm that what you are seeing here is different to #90 ?

@nickstenning
Copy link
Contributor

I've tried pretty much everything I can think of to reproduce this, including pretty much every entry in a matrix with the following axes:

  • same user/different users
  • public/in a group
  • annotations/page notes
  • creating/updating/deleting
  • annotating strictly before/strictly after/overlapping start/overlapping end/exact match/inside
  • heavily annotated pages/lightly annotated pages

And I haven't seen the issue described once, I'm afraid.

Could you confirm that you were using the latest client release, v0.39.0, which fixed exactly this issue, which Jeremy previously reported here.

@jeremydean
Copy link

it's hard for me to see in the video that the annotation is actually destroyed as opposed to just moving so far from view that it is basically lost to me, especially given how many annotations are on the page. could it just have moved so far in the sidebar--and/or the location in the PDF moved as well?

@judell
Copy link
Contributor Author

judell commented Sep 12, 2016

@jeremydean that might indeed be the situation.

Consider:

http://jonudell.net/h/reply-seemingly-gone-when-concurrent-annotations-flow-in.mp4

The setup here: A Python script is pumping in annotations from 4 different users, once per second, while a reply is in progress. Pretty quickly the in-progress annotation seems to vanish. I can reproduce this behavior at will.

I can't go back in time and check the prior screencast. Was the in-progress card still there somewhere? Seems plausible, especially on a heavily-annotated page.

@jeremydean
Copy link

jeremydean commented Sep 12, 2016

Right, a key here is the number of concurrent annotators/annotations. @robertknight @nickstenning

@robertknight
Copy link
Member

@judell - Can you provide the script you are using and any other setup details please? I'd like to reproduce this for myself.

@judell
Copy link
Contributor Author

judell commented Sep 12, 2016

@robertknight Yes, I'll send it to you directly because it includes tokens.

@judell
Copy link
Contributor Author

judell commented Sep 12, 2016

Closing in favor of #90

@judell judell closed this as completed Sep 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants