-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
when user a annotates, user b's in-progress annotation is destroyed #92
Comments
@judell - It is difficult to see exactly what is going on because that page has a large number of annotations. Unless it is crucial to reproducing or understanding the issue, it is much easier to see what is happening if you have the simplest possible test case. Can you also confirm that what you are seeing here is different to #90 ? |
I've tried pretty much everything I can think of to reproduce this, including pretty much every entry in a matrix with the following axes:
And I haven't seen the issue described once, I'm afraid. Could you confirm that you were using the latest client release, v0.39.0, which fixed exactly this issue, which Jeremy previously reported here. |
it's hard for me to see in the video that the annotation is actually destroyed as opposed to just moving so far from view that it is basically lost to me, especially given how many annotations are on the page. could it just have moved so far in the sidebar--and/or the location in the PDF moved as well? |
@jeremydean that might indeed be the situation. Consider: http://jonudell.net/h/reply-seemingly-gone-when-concurrent-annotations-flow-in.mp4 The setup here: A Python script is pumping in annotations from 4 different users, once per second, while a reply is in progress. Pretty quickly the in-progress annotation seems to vanish. I can reproduce this behavior at will. I can't go back in time and check the prior screencast. Was the in-progress card still there somewhere? Seems plausible, especially on a heavily-annotated page. |
Right, a key here is the number of concurrent annotators/annotations. @robertknight @nickstenning |
@judell - Can you provide the script you are using and any other setup details please? I'd like to reproduce this for myself. |
@robertknight Yes, I'll send it to you directly because it includes tokens. |
Closing in favor of #90 |
Screencast
http://jonudell.net/h/browser-a-kills-in-progress-annotation-in-browser-b.mp4
Setup:
Behavior:
The text was updated successfully, but these errors were encountered: