Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

YouTube URL bug #1533

Closed
LordMartron94 opened this issue Mar 18, 2024 · 9 comments
Closed

YouTube URL bug #1533

LordMartron94 opened this issue Mar 18, 2024 · 9 comments

Comments

@LordMartron94
Copy link

LordMartron94 commented Mar 18, 2024

Bug report form

Steps to reproduce

  1. Install Librewolf
  2. Use the Hypothesis bookmarklet on YouTube
  3. Annotate
  4. You will see the source URL is Youtube.com and not the actual video you are watching. The href in the rel=canonical of the source code is updated correctly, so this is most likely not the issue.

Expected behaviour

The source URL should be the actual video we are watching.

Actual behaviour

The source URL is YouTube.com home page.

Browser/system information

I am using the latest version of Librewolf currently available and Windows 11.

@LordMartron94
Copy link
Author

Update: it happens on Chrome browser, too, now... Maybe it's a Windows 11 thing?

@robertknight
Copy link
Member

I'm not able to reproduce in Chrome using the extension. Steps tested:

  1. Go to a YouTube.com video URL directly (ie. don't first go to youtube.com and then navigate)
  2. Activate the client, go to Help -> Version and see that the displayed URL is correct
  3. Create an annotation. The source URI will match the payload.

Note that if you do go to the homepage first, and then navigate to a video, it won't work. This is because of the issue where the link rel=canonical is not updated on youtube.com when client-side navigations happen. That's a known issue and is tracked in #1288.

@LordMartron94
Copy link
Author

Even after I refresh on the page, it still happens.

@robertknight
Copy link
Member

Can you provide the exact URL of the page you are testing with. Also can you confirm whether the URL that shows up under Help -> Version in the client matches the page URL.

@LordMartron94
Copy link
Author

image

Hmm, apparently if I copy the URL and paste it in a new tab it does work.

image

PS) thanks for the quick replies

@LordMartron94
Copy link
Author

It is friction to copy/paste the URL each time, though... Since when is this necessary? When I used hypothes.is before, last in September 2023, this was not a thing.

@robertknight
Copy link
Member

I can see from the screenshot that you're using an old version of the client, and it looks like it is not an official build. The current extension release is v1.1461.0. Before doing anything else, I would suggest updating to a current version.

Hmm, apparently if I copy the URL and paste it in a new tab it does work.

This sounds as though whatever you are doing to "refresh the page" is not actually refreshing the page fully but perhaps using a cached version of it. Check the link[rel=canonical] value in the page by evaluating document.querySelector('link[rel=canonical]').href in devtools and see whether it aligns with the URL shown in the sidebar.

@LordMartron94
Copy link
Author

Where can I update? I am on Librewolf, a fork of Firefox.

@LordMartron94
Copy link
Author

Refresh appears to be working now. I will close the issue. Thanks for your help. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants