Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement OAuth authorization endpoint for first-party accounts #310

Closed
robertknight opened this issue Jun 6, 2017 · 0 comments
Closed
Assignees
Labels

Comments

@robertknight
Copy link
Member

robertknight commented Jun 6, 2017

Implement an OAuth authorization endpoint that allows users to grant browser-based clients access to data in their Hypothesis accounts.

For context and design discussion, see Client OAuth Login Technical Design.

Acceptance criteria

  1. There is an endpoint, provisionally at GET /oauth/authorize, which clients can open in a popup window in order to authorize the client to access the user's data on Hypothesis.
  2. When a pre-registered client directs the user to this endpoint, the endpoint verifies the client ID and reports an error if it is unrecognized.
  3. If the user is logged in to the service when they visit this endpoint, they are prompted to allow the client to Accept / Deny the client access to the user's data.
  4. If the user is not logged in, they are first shown the login form and then sent to step 3.
  5. After the user accepts, an auth code is generated and delivered back to the client as described in the design document.
  6. If the user rejects or closes the auth prompt, an error is delivered back to the client as described in the design doc.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant