Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add GitHub environment URLs #821

Closed
seanh opened this issue Oct 24, 2022 · 1 comment
Closed

Add GitHub environment URLs #821

seanh opened this issue Oct 24, 2022 · 1 comment
Assignees
@seanh

Comments

@seanh
Copy link
Contributor

seanh commented Oct 24, 2022

Depends on #820.

GitHub lets deployment workflows associate a single URL with each environment and handily links to this URL in various places where environments and deployments to environments appear in the GitHub UI.

This would be a useful feature to have so we should add it to our deployment workflows. Unfortunately our deployment workflows don't currently create a separate GitHub environment for each Elastic Beanstalk environment, so we need to fix #820 before we can do this
@seanh seanh self-assigned this Oct 24, 2022
This was referenced Oct 27, 2022
Closed
Merged
seanh referenced this issue in hypothesis/workflows Oct 24, 2022
@seanh
Add new deploy.yml shared workflow
e6a95d2 
Part of https://github.com/hypothesis/workflows/issues/3 and
https://github.com/hypothesis/workflows/issues/4.

Add a new `deploy.yml` shared workflow which is similar to the existing
`eb-update.yml` workflow but allows the caller to provide the GitHub
environment name and URL as inputs.

This will enable us to change the caller workflows in each of our app
repos one-by-one to call the new `deploy.yml` workflow instead of
`eb-update.yml`, correcting the GitHub environment names and adding
environment URLs to each app repo one by one. Once all app repos have
been moved over we can then finally delete the original `eb-update.yml`.
seanh referenced this issue in hypothesis/workflows Oct 24, 2022
@seanh
Add new deploy.yml shared workflow
e2a8786 
Part of https://github.com/hypothesis/workflows/issues/3 and
https://github.com/hypothesis/workflows/issues/4.

Add a new `deploy.yml` shared workflow which is similar to the existing
`eb-update.yml` workflow but allows the caller to provide the GitHub
environment name and URL as inputs.

This will enable us to change the caller workflows in each of our app
repos one-by-one to call the new `deploy.yml` workflow instead of
`eb-update.yml`, correcting the GitHub environment names and adding
environment URLs to each app repo one by one. Once all app repos have
been moved over we can then finally delete the original `eb-update.yml`.
seanh referenced this issue in hypothesis/workflows Oct 25, 2022
@seanh
Add new deploy.yml shared workflow
979b2c0 
Part of https://github.com/hypothesis/workflows/issues/3 and
https://github.com/hypothesis/workflows/issues/4.

Add a new `deploy.yml` shared workflow which is similar to the existing
`eb-update.yml` workflow but allows the caller to provide the GitHub
environment name and URL as inputs.

This will enable us to change the caller workflows in each of our app
repos one-by-one to call the new `deploy.yml` workflow instead of
`eb-update.yml`, correcting the GitHub environment names and adding
environment URLs to each app repo one by one. Once all app repos have
been moved over we can then finally delete the original `eb-update.yml`.
@seanh seanh transferred this issue from hypothesis/workflows Oct 27, 2022
@seanh
Copy link
Contributor Author

seanh commented Oct 27, 2022

This was fixed by #818

@seanh seanh closed this as completed Oct 27, 2022
This was referenced Oct 27, 2022
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@seanh seanh

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@seanh