Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: create an option to hide hypothesis from people who don't have accounts in WP #1

Closed
billfitzgerald opened this issue Apr 23, 2014 · 2 comments

Comments

@billfitzgerald
Copy link

We are looking into adding functionality that would hide the hypothes.is functionality from people who didn't have accounts on the wordpress site.

Our use case is for people who are reading/accessing material on the site as part of a learning community/class. They would all have accounts on the WP site.

For this use case, we would want to hide the Hypothesis tab from people who did not have accounts, and show it to everyone else.
hypothesis_tab

This functionality could be toggled on the Pressbooks Textbooks admin screen.

hypothesis_auth

We'll gladly write the code for this, but before we dug in we wanted to check that this functionality makes sense/aligns with what you would want to support down the road.

@timmmmyboy
Copy link
Contributor

This makes complete sense to me. If you're willing to write please feel free to fork the code and then do a pull request. The current GitHub repo is what's in the WordPress plugin repository. I'm less familiar with the interaction of Pressbooks with this but I'm happy to help in supporting. I built this plugin originally as a test to see how difficult it would be to build a plugin that adds JS to the header of the WP theme (turns out not too difficult!). I only say that to set the expectation of where my level of experience is. I don't consider myself much of a programmer, more a hack that can read and understand PHP enough to parse what's happening with other people's code. I think the setting you're suggesting makes a lot of sense though so let me know if I can help in any way.

@billfitzgerald
Copy link
Author

Thanks for chiming in here - we'll take a look at this and ping back with either a pull request or questions!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants