Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle PDFs hosted via WordPress on other file storage systems #29

Open
xolotl opened this issue Oct 19, 2017 · 1 comment
Open

handle PDFs hosted via WordPress on other file storage systems #29

xolotl opened this issue Oct 19, 2017 · 1 comment

Comments

@xolotl
Copy link
Contributor

xolotl commented Oct 19, 2017

When WordPress is configured to host its Media Library in a different environment than the local file system (eg, AWS S3), this plugin doesn't launch the Hypothesis client with PDFs stored in such a
"foreign" Media Library using via.hypothes.is. This may have to do with cross-domain issues.

To recreate:

  • Use a WP instance configured to store its Media Library in another place (eg, an AWS S3 plugin like https://deliciousbrains.com/wp-offload-s3/).
  • Upload a PDF to the Media Library and verify it is stored in an alternate location (eg, AWS S3).
  • Navigate to the PDF location and verify that it launches without via.hypothes.is.
  • You may be able to test the issue by forcing the PDF to be stored locally again and launch it to see if it then launches with via.hypothes.is.
@xolotl
Copy link
Contributor Author

xolotl commented Oct 19, 2017

There are a couple of workarounds:

  • If the WP setup does allow specific files to be hosted locally as exceptions, then that should work.
  • When making a link to an externally hosted PDF, one can manually prefix via.hypothes.is in the link.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant