Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Configuration not read from included files #84

Closed
dantefromhell opened this issue Apr 16, 2024 · 1 comment
Closed

[BUG] Configuration not read from included files #84

dantefromhell opened this issue Apr 16, 2024 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@dantefromhell
Copy link
Contributor

Pyprland version
Which version did you use? (copy & paste the string returned by pypr version)

❯ pypr version
2.2.7

Describe the bug

Configuration settings in files added via the include config option are not added to overall configuration.

Example ~/.config/hypr/pyprland.toml

[pyprland]
plugins = [ "scratchpads" ]
include = ["~/.config/overrides/pyprland/99__testing.toml"]

[scratchpads.kitty]
command = "kitty --class kitty-scratchpad"
lazy = false
size = "74% 60%"
position = "13% 7%"
alt_toggle = true

And file /home/dante/.config/overrides/pyprland/99__testing.toml

[scratchpads.betterbird]
command = "betterbird"
animation = "fromRight"
lazy = true
alt_toggle = true

Yields the following behaviour when manually toggling scratchpads

  • ❯ pypr toggle kitty working as expected
  • ❯ pypr toggle betterbird triggering an error message saying Scratchpad betterbird not found
@dantefromhell dantefromhell added the bug Something isn't working label Apr 16, 2024
@fdev31
Copy link
Collaborator

fdev31 commented Apr 16, 2024

Having a single plugin spread into several files can be hard to predict and is then an implementation detail which I would not like have to describe and should be able to change in the future.
If you have all the scratchpads in one file does it work ?

@fdev31 fdev31 closed this as completed in 25ce2b7 Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants