Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cannot build hyprland with latest wlroots #1134

Closed
apprehensions opened this issue Nov 30, 2022 · 27 comments
Closed

cannot build hyprland with latest wlroots #1134

apprehensions opened this issue Nov 30, 2022 · 27 comments
Labels
bug Something isn't working

Comments

@apprehensions
Copy link
Contributor

wlroots commit 0611c10, hyprland fails to compile.

[119/376] Generating subprojects/wlroots/render/vulkan/shaders/common.vert_spv with a custom command
ninja: job failed: c++ -Isrc/Hyprland.p -Isrc -I../src -Isubprojects/wlroots/include -I../subprojects/wlroots/include -Iprotocols -I/usr/include/libdrm -I/usr/include/pixman-1 -I/usr/include/cairo -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/freetype2 -I/usr/include/libpng16 -I/usr/include/harfbuzz -I/usr/include/pango-1.0 -fdiagnostics-color=always -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wnon-virtual-dtor -Wextra -O3 -g -Wno-unused-parameter -Wno-unused-value -Wno-missing-field-initializers -Wno-narrowing '-DGIT_BRANCH=""' '-DGIT_COMMIT_HASH=""' '-DGIT_COMMIT_MESSAGE=""' '-DGIT_DIRTY="dirty"' -DHYPRLAND_DEBUG -std=c++23 -O3 -pipe -w -march=native -pthread -DWLR_USE_UNSTABLE -MD -MQ src/Hyprland.p/helpers_SubsurfaceTree.cpp.o -MF src/Hyprland.p/helpers_SubsurfaceTree.cpp.o.d -o src/Hyprland.p/helpers_SubsurfaceTree.cpp.o -c ../src/helpers/SubsurfaceTree.cpp
../src/helpers/SubsurfaceTree.cpp: In function 'void addSurfaceGlobalOffset(SSurfaceTreeNode*, int*, int*)':
../src/helpers/SubsurfaceTree.cpp:6:28: error: 'struct wlr_surface' has no member named 'sx'
    6 |     *lx += node->pSurface->sx;
      |                            ^~
../src/helpers/SubsurfaceTree.cpp:7:28: error: 'struct wlr_surface' has no member named 'sy'
    7 |     *ly += node->pSurface->sy;
      |                            ^~
ninja: job failed: c++ -Isrc/Hyprland.p -Isrc -I../src -Isubprojects/wlroots/include -I../subprojects/wlroots/include -Iprotocols -I/usr/include/libdrm -I/usr/include/pixman-1 -I/usr/include/cairo -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/freetype2 -I/usr/include/libpng16 -I/usr/include/harfbuzz -I/usr/include/pango-1.0 -fdiagnostics-color=always -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wnon-virtual-dtor -Wextra -O3 -g -Wno-unused-parameter -Wno-unused-value -Wno-missing-field-initializers -Wno-narrowing '-DGIT_BRANCH=""' '-DGIT_COMMIT_HASH=""' '-DGIT_COMMIT_MESSAGE=""' '-DGIT_DIRTY="dirty"' -DHYPRLAND_DEBUG -std=c++23 -O3 -pipe -w -march=native -pthread -DWLR_USE_UNSTABLE -MD -MQ src/Hyprland.p/Compositor.cpp.o -MF src/Hyprland.p/Compositor.cpp.o.d -o src/Hyprland.p/Compositor.cpp.o -c ../src/Compositor.cpp
../src/Compositor.cpp: In constructor 'CCompositor::CCompositor()':
../src/Compositor.cpp:56:43: error: too few arguments to function 'wlr_backend* wlr_backend_autocreate(wl_display*, wlr_session**)'
   56 |     m_sWLRBackend = wlr_backend_autocreate(m_sWLDisplay);
      |                     ~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~
In file included from ../src/includes.hpp:37,
                 from ../src/defines.hpp:1,
                 from ../src/Compositor.hpp:7,
                 from ../src/Compositor.cpp:1:
../subprojects/wlroots/include/wlr/backend.h:41:21: note: declared here
   41 | struct wlr_backend *wlr_backend_autocreate(struct wl_display *display,
      |                     ^~~~~~~~~~~~~~~~~~~~~~
../src/Compositor.cpp:135:49: error: too few arguments to function 'wlr_layer_shell_v1* wlr_layer_shell_v1_create(wl_display*, uint32_t)'
  135 |     m_sWLRLayerShell = wlr_layer_shell_v1_create(m_sWLDisplay);
      |                        ~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~
In file included from ../src/includes.hpp:54:
../subprojects/wlroots/include/wlr/types/wlr_layer_shell_v1.h:125:28: note: declared here
  125 | struct wlr_layer_shell_v1 *wlr_layer_shell_v1_create(struct wl_display *display,
      |                            ^~~~~~~~~~~~~~~~~~~~~~~~~
../src/Compositor.cpp:176:21: error: 'wlr_backend_get_session' was not declared in this scope; did you mean 'wlr_backend_get_drm_fd'?
  176 |     m_sWLRSession = wlr_backend_get_session(m_sWLRBackend);
      |                     ^~~~~~~~~~~~~~~~~~~~~~~
      |                     wlr_backend_get_drm_fd
ninja: subcommands failed
@apprehensions apprehensions added the bug Something isn't working label Nov 30, 2022
@vaxerski
Copy link
Member

hyprland & wlroots ver mismatch. make sure to always git submodule update --init after each pull or pull with --recurse-submodules

@apprehensions
Copy link
Contributor Author

i cannot do this without using direct git cloning, which is related to #1133

@vaxerski
Copy link
Member

vaxerski commented Nov 30, 2022

the source and binaries provided in the tarball should work.

Otherwise, git cloning is your only option (unless your distro packages hyprland)

I can also see you're using meson - tried CMake?

@apprehensions
Copy link
Contributor Author

wlroots| Found CMake: /usr/bin/cmake (3.25.0)
yes

@apprehensions
Copy link
Contributor Author

the source and binaries provided in the tarball should work.

#1133 like i said, as i am trying to

(unless your distro packages hyprland)

myself.

@vaxerski
Copy link
Member

I meant building with cmake. You're using meson in the above screenshot.

sudo make install

@apprehensions
Copy link
Contributor Author

I meant building with cmake. You're using meson in the above screenshot.

well that wont work because of #1133 and not using the meson subprojects feature.

Package wlroots was not found in the pkg-config search path.
Perhaps you should add the directory containing `wlroots.pc'
to the PKG_CONFIG_PATH environment variable
Package 'wlroots', required by 'virtual:world', not found
Package wlroots was not found in the pkg-config search path.
Perhaps you should add the directory containing `wlroots.pc'
to the PKG_CONFIG_PATH environment variable
Package 'wlroots', required by 'virtual:world', not found
/usr/bin/wayland-scanner server-header \
        //usr/share/wayland-protocols/stable/xdg-shell/xdg-shell.xml xdg-shell-protocol.h
Package wlroots was not found in the pkg-config search path.
Perhaps you should add the directory containing `wlroots.pc'
to the PKG_CONFIG_PATH environment variable
Package 'wlroots', required by 'virtual:world', not found

after installing wlroots 0.16.0:

[216/412] Compiling C object libwlroots.so.12032.p/util_box.c.o
ninja: job failed: cc -Ilibwlroots.so.12032.p -I. -I.. -Iinclude -I../include -Iprotocol -I../protocol -Irender/gles2/shaders -Irender/vulkan/shaders -Ibackend/drm -I/usr/include/libdrm -I/usr/include/pixman-1 -fdiagnostics-color=always -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wextra -Werror -std=c11 -O3 -DWLR_LITTLE_ENDIAN=1 -DWLR_BIG_ENDIAN=0 -Wundef -Wlogical-op -Wmissing-include-dirs -Wold-style-definition -Wpointer-arith -Winit-self -Wstrict-prototypes -Wimplicit-fallthrough=2 -Wendif-labels -Wstrict-aliasing=2 -Woverflow -Wmissing-prototypes -Walloca -Wno-missing-braces -Wno-missing-field-initializers -Wno-unused-parameter -fmacro-prefix-map=../= -DHAS_GBM_BO_GET_FD_FOR_PLANE=1 -DLIBINPUT_HAS_HOLD_GESTURES=1 -DLIBINPUT_HAS_SCROLL_VALUE120=1 '-DICONDIR="/usr/local/share/icons"' -DHAS_XCB_XFIXES_SET_CLIENT_DISCONNECT_MODE=1 -DHAS_XCB_ERRORS=0 -DHAS_EGL=1 -O3 -pipe -w -march=native -DXWAYLAND -DWLR_USE_UNSTABLE -std=c99 -fPIC -MD -MQ libwlroots.so.12032.p/xwayland_selection_outgoing.c.o -MF libwlroots.so.12032.p/xwayland_selection_outgoing.c.o.d -o libwlroots.so.12032.p/xwayland_selection_outgoing.c.o -c ../xwayland/selection/outgoing.c
In file included from ../include/wlr/types/wlr_data_device.h:13,
                 from ../xwayland/selection/outgoing.c:7:
../include/wlr/types/wlr_seat.h:242:25: error: field 'last_event' has incomplete type
  242 |         struct timespec last_event;
      |                         ^~~~~~~~~~
ninja: job failed: cc -Ilibwlroots.so.12032.p -I. -I.. -Iinclude -I../include -Iprotocol -I../protocol -Irender/gles2/shaders -Irender/vulkan/shaders -Ibackend/drm -I/usr/include/libdrm -I/usr/include/pixman-1 -fdiagnostics-color=always -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wextra -Werror -std=c11 -O3 -DWLR_LITTLE_ENDIAN=1 -DWLR_BIG_ENDIAN=0 -Wundef -Wlogical-op -Wmissing-include-dirs -Wold-style-definition -Wpointer-arith -Winit-self -Wstrict-prototypes -Wimplicit-fallthrough=2 -Wendif-labels -Wstrict-aliasing=2 -Woverflow -Wmissing-prototypes -Walloca -Wno-missing-braces -Wno-missing-field-initializers -Wno-unused-parameter -fmacro-prefix-map=../= -DHAS_GBM_BO_GET_FD_FOR_PLANE=1 -DLIBINPUT_HAS_HOLD_GESTURES=1 -DLIBINPUT_HAS_SCROLL_VALUE120=1 '-DICONDIR="/usr/local/share/icons"' -DHAS_XCB_XFIXES_SET_CLIENT_DISCONNECT_MODE=1 -DHAS_XCB_ERRORS=0 -DHAS_EGL=1 -O3 -pipe -w -march=native -DXWAYLAND -DWLR_USE_UNSTABLE -std=c99 -fPIC -MD -MQ libwlroots.so.12032.p/xwayland_selection_dnd.c.o -MF libwlroots.so.12032.p/xwayland_selection_dnd.c.o.d -o libwlroots.so.12032.p/xwayland_selection_dnd.c.o -c ../xwayland/selection/dnd.c
In file included from ../include/wlr/types/wlr_data_device.h:13,
                 from ../xwayland/selection/dnd.c:6:
../include/wlr/types/wlr_seat.h:242:25: error: field 'last_event' has incomplete type
  242 |         struct timespec last_event;
      |                         ^~~~~~~~~~
ninja: subcommands failed
make: *** [Makefile:134: install] Error 1

@vaxerski
Copy link
Member

vaxerski commented Nov 30, 2022

that is really odd, you're doing something not right. Hyprland should never try to use system wlroots. The dep in CMakeLists is the subproject, not a system dep

@apprehensions
Copy link
Contributor Author

so... can you fix #1133 so this can be solved? or do i have to fork wlroots as a package for this?

@vaxerski
Copy link
Member

how is that related to 1133? Yes I could rename it and fix the tarbomb with the next release, but what would that change in this sense? It seems like you're trying to force build Hyprland against a tagged wlroots, which will never work. See #302

You do not need to package wlroots separately. You can keep it as a part of Hyprland and install the separate .so in /usr/lib. (or wherever your distro puts shared objects) The so has a different name than any packaged wlroots, so it will not create a conflict.

Although I understand the situation with the tarballs, I fail to see a problem.

You are not supposed to use the GitHub generated sources. There is an attached source- tarball for a reason. It will also contain the correct wlroots dep.

It is a tarbomb. Yes, oops. The problem with changing that now is we are breaking already existing packages if we change that. (e.g. AUR) Although the AUR can be updated easily by me, I have no clue what else may break. Can't you mkdir and decopmress to that folder? I might consider making a separate sources-v2- that is not a tarbomb as a transition.

The name of the binaries' tarball is the same as the github sources. Yes, but it doesn't matter. The links are different, and you're not supposed to use the GH sources anyways.

@apprehensions
Copy link
Contributor Author

There is an attached source- tarball for a reason. It will also contain the correct wlroots dep.

Which is why i want to use them. but i cannot because of the tarball scheme.
I cannot use the provided 'source' tarball as they are broken, and i shouldn't use the GH sources, so i guess my only choice is a direct git clone untill this is solved.

@vaxerski
Copy link
Member

I will sort it out with the next release.

@apprehensions
Copy link
Contributor Author

apprehensions commented Nov 30, 2022

i still can't compile hyprland, latest wlroots and latest hyprland with git sources.

[236/411] Compiling C object libwlroots.so.12032.p/types_wlr_switch.c.o
[237/411] Compiling C object libwlroots.so.12032.p/types_wlr_subcompositor.c.o
ninja: job failed: cc -Ilibwlroots.so.12032.p -I. -I.. -Iinclude -I../include -Iprotocol -I../protocol -Irender/gles2/shaders -Irender/vulkan/shaders -Ibackend/drm -I/usr/include/libdrm -I/usr/include/pixman-1 -fdiagnostics-color=always -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wextra -Werror -std=c11 -O3 -DWLR_LITTLE_ENDIAN=1 -DWLR_BIG_ENDIAN=0 -Wundef -Wlogical-op -Wmissing-include-dirs -Wold-style-definition -Wpointer-arith -Winit-self -Wstrict-prototypes -Wimplicit-fallthrough=2 -Wendif-labels -Wstrict-aliasing=2 -Woverflow -Wmissing-prototypes -Walloca -Wno-missing-braces -Wno-missing-field-initializers -Wno-unused-parameter -fmacro-prefix-map=../= -DHAS_GBM_BO_GET_FD_FOR_PLANE=1 -DLIBINPUT_HAS_HOLD_GESTURES=1 -DLIBINPUT_HAS_SCROLL_VALUE120=1 '-DICONDIR="/usr/local/share/icons"' -DHAS_XCB_XFIXES_SET_CLIENT_DISCONNECT_MODE=1 -DHAS_XCB_ERRORS=0 -DHAS_EGL=1 -O3 -pipe -w -march=native -DXWAYLAND -DWLR_USE_UNSTABLE -std=c99 -fPIC -MD -MQ libwlroots.so.12032.p/types_wlr_xdg_decoration_v1.c.o -MF libwlroots.so.12032.p/types_wlr_xdg_decoration_v1.c.o.d -o libwlroots.so.12032.p/types_wlr_xdg_decoration_v1.c.o -c ../types/wlr_xdg_decoration_v1.c
In file included from ../include/wlr/types/wlr_xdg_shell.h:14,
                 from ../include/wlr/types/wlr_xdg_decoration_v1.h:5,
                 from ../types/wlr_xdg_decoration_v1.c:4:
../include/wlr/types/wlr_seat.h:242:25: error: field 'last_event' has incomplete type
  242 |         struct timespec last_event;
      |                         ^~~~~~~~~~
ninja: job failed: cc -Ilibwlroots.so.12032.p -I. -I.. -Iinclude -I../include -Iprotocol -I../protocol -Irender/gles2/shaders -Irender/vulkan/shaders -Ibackend/drm -I/usr/include/libdrm -I/usr/include/pixman-1 -fdiagnostics-color=always -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wextra -Werror -std=c11 -O3 -DWLR_LITTLE_ENDIAN=1 -DWLR_BIG_ENDIAN=0 -Wundef -Wlogical-op -Wmissing-include-dirs -Wold-style-definition -Wpointer-arith -Winit-self -Wstrict-prototypes -Wimplicit-fallthrough=2 -Wendif-labels -Wstrict-aliasing=2 -Woverflow -Wmissing-prototypes -Walloca -Wno-missing-braces -Wno-missing-field-initializers -Wno-unused-parameter -fmacro-prefix-map=../= -DHAS_GBM_BO_GET_FD_FOR_PLANE=1 -DLIBINPUT_HAS_HOLD_GESTURES=1 -DLIBINPUT_HAS_SCROLL_VALUE120=1 '-DICONDIR="/usr/local/share/icons"' -DHAS_XCB_XFIXES_SET_CLIENT_DISCONNECT_MODE=1 -DHAS_XCB_ERRORS=0 -DHAS_EGL=1 -O3 -pipe -w -march=native -DXWAYLAND -DWLR_USE_UNSTABLE -std=c99 -fPIC -MD -MQ libwlroots.so.12032.p/types_wlr_virtual_pointer_v1.c.o -MF libwlroots.so.12032.p/types_wlr_virtual_pointer_v1.c.o.d -o libwlroots.so.12032.p/types_wlr_virtual_pointer_v1.c.o -c ../types/wlr_virtual_pointer_v1.c
In file included from ../types/wlr_virtual_pointer_v1.c:4:
../include/wlr/types/wlr_seat.h:242:25: error: field 'last_event' has incomplete type
  242 |         struct timespec last_event;
      |                         ^~~~~~~~~~
ninja: job failed: cc -Ilibwlroots.so.12032.p -I. -I.. -Iinclude -I../include -Iprotocol -I../protocol -Irender/gles2/shaders -Irender/vulkan/shaders -Ibackend/drm -I/usr/include/libdrm -I/usr/include/pixman-1 -fdiagnostics-color=always -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wextra -Werror -std=c11 -O3 -DWLR_LITTLE_ENDIAN=1 -DWLR_BIG_ENDIAN=0 -Wundef -Wlogical-op -Wmissing-include-dirs -Wold-style-definition -Wpointer-arith -Winit-self -Wstrict-prototypes -Wimplicit-fallthrough=2 -Wendif-labels -Wstrict-aliasing=2 -Woverflow -Wmissing-prototypes -Walloca -Wno-missing-braces -Wno-missing-field-initializers -Wno-unused-parameter -fmacro-prefix-map=../= -DHAS_GBM_BO_GET_FD_FOR_PLANE=1 -DLIBINPUT_HAS_HOLD_GESTURES=1 -DLIBINPUT_HAS_SCROLL_VALUE120=1 '-DICONDIR="/usr/local/share/icons"' -DHAS_XCB_XFIXES_SET_CLIENT_DISCONNECT_MODE=1 -DHAS_XCB_ERRORS=0 -DHAS_EGL=1 -O3 -pipe -w -march=native -DXWAYLAND -DWLR_USE_UNSTABLE -std=c99 -fPIC -MD -MQ libwlroots.so.12032.p/xwayland_selection_outgoing.c.o -MF libwlroots.so.12032.p/xwayland_selection_outgoing.c.o.d -o libwlroots.so.12032.p/xwayland_selection_outgoing.c.o -c ../xwayland/selection/outgoing.c
In file included from ../include/wlr/types/wlr_data_device.h:13,
                 from ../xwayland/selection/outgoing.c:7:
../include/wlr/types/wlr_seat.h:242:25: error: field 'last_event' has incomplete type
  242 |         struct timespec last_event;
      |                         ^~~~~~~~~~
ninja: job failed: cc -Ilibwlroots.so.12032.p -I. -I.. -Iinclude -I../include -Iprotocol -I../protocol -Irender/gles2/shaders -Irender/vulkan/shaders -Ibackend/drm -I/usr/include/libdrm -I/usr/include/pixman-1 -fdiagnostics-color=always -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wextra -Werror -std=c11 -O3 -DWLR_LITTLE_ENDIAN=1 -DWLR_BIG_ENDIAN=0 -Wundef -Wlogical-op -Wmissing-include-dirs -Wold-style-definition -Wpointer-arith -Winit-self -Wstrict-prototypes -Wimplicit-fallthrough=2 -Wendif-labels -Wstrict-aliasing=2 -Woverflow -Wmissing-prototypes -Walloca -Wno-missing-braces -Wno-missing-field-initializers -Wno-unused-parameter -fmacro-prefix-map=../= -DHAS_GBM_BO_GET_FD_FOR_PLANE=1 -DLIBINPUT_HAS_HOLD_GESTURES=1 -DLIBINPUT_HAS_SCROLL_VALUE120=1 '-DICONDIR="/usr/local/share/icons"' -DHAS_XCB_XFIXES_SET_CLIENT_DISCONNECT_MODE=1 -DHAS_XCB_ERRORS=0 -DHAS_EGL=1 -O3 -pipe -w -march=native -DXWAYLAND -DWLR_USE_UNSTABLE -std=c99 -fPIC -MD -MQ libwlroots.so.12032.p/xwayland_selection_dnd.c.o -MF libwlroots.so.12032.p/xwayland_selection_dnd.c.o.d -o libwlroots.so.12032.p/xwayland_selection_dnd.c.o -c ../xwayland/selection/dnd.c
In file included from ../include/wlr/types/wlr_data_device.h:13,
                 from ../xwayland/selection/dnd.c:6:
../include/wlr/types/wlr_seat.h:242:25: error: field 'last_event' has incomplete type
  242 |         struct timespec last_event;
      |                         ^~~~~~~~~~
ninja: subcommands failed
make: *** [Makefile:137: install] Error 1

to preproduce:

git submodule update --init
make
make install

@apprehensions
Copy link
Contributor Author

Yes, i face this an a previous issue with latest wlroots,

ninja: job failed: ccache c++ -Isrc/Hyprland.p -Isrc -I../src -Isubprojects/wlroots/include -I../subprojects/wlroots/include -Iprotocols -I/usr/include/libdrm -I/usr/include/pixman-1 -I/usr/include/cairo -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/freetype2 -I/usr/include/libpng16 -I/usr/include/harfbuzz -I/usr/include/pango-1.0 -fdiagnostics-color=always -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wnon-virtual-dtor -Wextra -O3 -g -Wno-unused-parameter -Wno-unused-value -Wno-missing-field-initializers -Wno-narrowing '-DGIT_BRANCH=""' '-DGIT_COMMIT_HASH=""' '-DGIT_COMMIT_MESSAGE=""' '-DGIT_DIRTY="dirty"' -DHYPRLAND_DEBUG -std=c++23 -O3 -pipe -w -march=native -pthread -DWLR_USE_UNSTABLE -MD -MQ src/Hyprland.p/helpers_SubsurfaceTree.cpp.o -MF src/Hyprland.p/helpers_SubsurfaceTree.cpp.o.d -o src/Hyprland.p/helpers_SubsurfaceTree.cpp.o -c ../src/helpers/SubsurfaceTree.cpp
../src/helpers/SubsurfaceTree.cpp: In function 'void addSurfaceGlobalOffset(SSurfaceTreeNode*, int*, int*)':
../src/helpers/SubsurfaceTree.cpp:6:28: error: 'struct wlr_surface' has no member named 's '
    6 |     *lx += node->pSurface->sx;
      |                            ^~
../src/helpers/SubsurfaceTree.cpp:7:28: error: 'struct wlr_surface' has no member named 's '
    7 |     *ly += node->pSurface->sy;
      |                            ^~
ninja: subcommand failed

some hyprland code should be changed for the latest wlroots?

@vaxerski
Copy link
Member

Hyprland does NOT use the latest wlroots. It uses a pinned commit that is updated by me manually every week or two.

@apprehensions
Copy link
Contributor Author

Hyprland does NOT use the latest wlroots

.gitmodules says otherwise.

What is the specified commit?

@vaxerski
Copy link
Member

.gitmodules is not where a commit lock is located. That would be in .git/'s metadata.

You can view the tree at any point and see the commit's abbrev-ref if you go into submodules/

@apprehensions
Copy link
Contributor Author

this wlroots commit: https://gitlab.freedesktop.org/wlroots/wlroots/-/tree/4ff46e6cf9463e594605928feeb7c55cf323b5e7

,...hyprland still fails with the same error.

@vaxerski
Copy link
Member

... that's the HEAD's lock. Did you even read what I said? You are compiling a release. You need to go back to the release's tree.

@apprehensions
Copy link
Contributor Author

You can view the tree at any point and see the commit's abbrev-ref if you go into submodules/

2022-11-30_15-01-33

Okay... maybe i understood wrong

@apprehensions
Copy link
Contributor Author

i still don't know exactly how to retrieve the commit.

@vaxerski
Copy link
Member

jfc

image
image
image
image

@apprehensions
Copy link
Contributor Author

apprehensions commented Nov 30, 2022

ok well, yeah i was not using 0.18.0beta, but hyprland would still fail to compile on latest HEAD (ff4ea1a) and latest subproject wlroots (4ff46e6) commit.

so i guess there was an misunderstanding.
i did want to use latest hyprland HEAD for newer features...

@apprehensions
Copy link
Contributor Author

IT STILL FAILS.

@apprehensions
Copy link
Contributor Author

i wanted to go on the discord for easy communication, however the discord server requires a phone number, and I'd rather not give that away to a company like Discord, when many FOSS discord servers don't have this in place.

@apprehensions
Copy link
Contributor Author

so, using the native Makefile method, which calls meson and then Cmake, makes hyprland fail. but using native meson makes it have a linking error.

@apprehensions
Copy link
Contributor Author

i got it to work with installation of xcb-util-renderutil.

it was weird that it wouldn't work, but as of right now i am not using cmake, only native meson.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants