Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support intersection(::BSplineSpace, ::BSplineSpace)? #198

Closed
hyrodium opened this issue Apr 9, 2022 · 1 comment
Closed

Support intersection(::BSplineSpace, ::BSplineSpace)? #198

hyrodium opened this issue Apr 9, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@hyrodium
Copy link
Owner

hyrodium commented Apr 9, 2022

In BasicBSpline, BSplineSpace (AbstractBSplineSpace) structs are regarded as a linear space, so we can compute their intersection and +.

I'm not sure we have practical benefits for the features.
@hyrodium
Copy link
Owner Author

+(::BSplineSpace, ::BSplineSpace) is not always BSplineSpace. Here are counter examples:

  • BSplineSpace{2}(KnotVector([0,0,0,1,1,1])) + BSplineSpace{3}(KnotVector([2,2,2,2,3,3,3,3]))
  • BSplineSpace{0}(KnotVector([0,1,2])) + BSplineSpace{3}(KnotVector([0,0,0,0,2,2,2,2]))

@hyrodium hyrodium added the enhancement New feature or request label May 27, 2022
@hyrodium hyrodium closed this as not planned Won't fix, can't repro, duplicate, stale Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@hyrodium