Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reconsider the names of exported function #269

Closed
hyrodium opened this issue Sep 8, 2022 · 2 comments
Closed

Reconsider the names of exported function #269

hyrodium opened this issue Sep 8, 2022 · 2 comments
Labels
breaking design help wanted Extra attention is needed

Comments

@hyrodium
Copy link
Owner

hyrodium commented Sep 8, 2022

BasicBSpline.jl defines and exports functions dim, domain and degree. It seems these namings are general and may conflict with other packages. I guess it might be better to rename or avoid exporting these functions.

@hyrodium hyrodium added help wanted Extra attention is needed design breaking labels Sep 8, 2022
@hyrodium
Copy link
Owner Author

hyrodium commented Oct 3, 2022

Maybe, it seems better to add the domain method to ApproxFunBase.domain.
https://juliaapproximation.github.io/ApproxFun.jl/latest/library/#ApproxFunBase.domain

@hyrodium
Copy link
Owner Author

hyrodium commented Jan 7, 2023

Maybe, it seems better to add the domain method to ApproxFunBase.domain.

No, the package is not lightweight. It seems okay to keep the names of the functions with general names because one can call the functions explicitly.

@hyrodium hyrodium closed this as completed Jan 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking design help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant