Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug around issubset with UniformKnotVector #293

Closed
hyrodium opened this issue Jan 2, 2023 · 1 comment
Closed

Bug around issubset with UniformKnotVector #293

hyrodium opened this issue Jan 2, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@hyrodium
Copy link
Owner

hyrodium commented Jan 2, 2023 •
edited 

julia> k1 = KnotVector([1,2,3,3])
KnotVector([1, 2, 3, 3])

julia> k2 = UniformKnotVector(1:3)
UniformKnotVector(1:3)

julia> k1 ⊆ k2  # This should be false
true

julia> k1 ⊆ KnotVector(k2)  # correct
false
@hyrodium hyrodium added the bug Something isn't working label Jan 3, 2023
@hyrodium
Copy link
Owner Author

hyrodium commented Jan 6, 2023

This is now fixed in the master branch. (by #292)

julia> k1 = KnotVector([1,2,3,3])
KnotVector([1, 2, 3, 3])

julia> k2 = UniformKnotVector(1:3)
UniformKnotVector(1:3)

julia> k1 ⊆ k2  # This should be false
false

julia> k1 ⊆ KnotVector(k2)  # correct
false

@hyrodium hyrodium closed this as completed Jan 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@hyrodium