Skip to content
This repository has been archived by the owner on Jul 27, 2023. It is now read-only.

Mission fail with new companion Elwyn #34

Closed
woefulwabbit opened this issue Aug 18, 2021 · 5 comments · Fixed by #36
Closed

Mission fail with new companion Elwyn #34

woefulwabbit opened this issue Aug 18, 2021 · 5 comments · Fixed by #36

Comments

@woefulwabbit
Copy link

Logs attached:
elwyn.log

Version is different, but the values for spell 306 match:
[306]={type="aura", target=3, duration=3, modMaxHP=60, plusDamageDealtATK=40}, --Arcane Empowerment (UNVERIFIED)

@boomboo
Copy link

boomboo commented Aug 18, 2021

I don't know if it caused the failure but modMaxHP is wrong and should be modMaxHPATK

@BradCOnGitHub
Copy link

Found it. There's a hard coded 20 follower limit in Widgets.lua on line 1960. I'm not sure if you can fix that from another addon.

@FlipperPA
Copy link
Contributor

@BradCOnGitHub I wish I'd read your comment first, I went hunting through the code myself... and just PR'd a change to the README!

@cremor
Copy link

cremor commented Aug 20, 2021

@BradCOnGitHub and @FlipperPA Are you sure that fixing the 20 follower limit in Widgets.lua actually fixes this mission fail? Isn't that only a fix for the follow list display?

@BradCOnGitHub
Copy link

BradCOnGitHub commented Aug 20, 2021

The other fix is needed too, but it doesn't cause a lua error. It was just using a percentage based HP buff instead of a fixed amount, which was wrong.

We probably hijacked the orginal issue here.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants