Skip to content
This repository has been archived by the owner on Jul 27, 2023. It is now read-only.

Is this still being maintained? #63

Closed
V1P3R opened this issue Oct 1, 2021 · 11 comments
Closed

Is this still being maintained? #63

V1P3R opened this issue Oct 1, 2021 · 11 comments

Comments

@V1P3R
Copy link

V1P3R commented Oct 1, 2021

for i=1,#C_Garrison.GetFollowers(123) do
on the follower count error is more efficient than
for i=1,99 do

though it can only show 24 and might lead to an error when you gain new followers, so perhaps hardcoding to 24 instead of 99 is the way to go.

@TruthNZ
Copy link

TruthNZ commented Oct 2, 2021

It leads to errors if you get a new follower and don't reload before opening your mission table.

Frankly I think that's a small price to pay. It's easy to reload. And is better than having to do more updates regularly.

@Divergentcurl
Copy link

I was wondering if this is still being maintained as well. If not, I wouldn't mind taking up that responsibility.

@woefulwabbit
Copy link

I was wondering if this is still being maintained as well. If not, I wouldn't mind taking up that responsibility.

This might be necessary, seeing as @hythloday hasn't been active in github since Aug 20. Unless someone else active has write access. @FlipperPA perhaps?

@majtymit
Copy link

bump

@k1ck3r
Copy link

k1ck3r commented Nov 1, 2021

please, as i wrote in another issue, take care of this repo (clone it, but keep it updated) until the owner decided to answer. just make a PR, before letting us know link to your PR

@Divergentcurl
Copy link

Divergentcurl commented Nov 3, 2021

I have forked this repo and am maintaining a cumulative-fixes branch, gathering all known fixes. It should be a bit more user-friendly than following the instructions in #60. Also, this branch now has fixes for 9.1.5.

@FlipperPA
Copy link
Contributor

Sorry I can't take over, @woefulwabbit - I'm in the process of moving houses. I'll contribute to @Divergentcurl's fork.

@FlipperPA
Copy link
Contributor

I've added a few PR fixes to @Divergentcurl's fork to the cumulative-fixes branch.

@k1ck3r
Copy link

k1ck3r commented Nov 10, 2021

@Divergentcurl Have one small suggestion, it's more QoL than actual funtion... Would you be so kind and rename the addon from Extra Missions for Venture Plan to something more like Venture Plan (Extra Missions)

Renaming it, will put your (and all other people's here work) addon to the alphabetical proper place - now it's the very start of list, while actual Venture Plan is at the end.

@Divergentcurl
Copy link

I agree and now remember that I was confused at first by the name in WoW as well. With the latest commit I have made it consistent with the other naming of the addon (the folder and on WoWInterface)

@k1ck3r
Copy link

k1ck3r commented Nov 12, 2021

Thank you SO MUCH !!! <3 now publish this shit into WoWup :"))))

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants