Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inconsistent between .fq.gz and .fastq? #4

Closed
AMChalkie opened this issue Dec 2, 2019 · 7 comments
Closed

inconsistent between .fq.gz and .fastq? #4

AMChalkie opened this issue Dec 2, 2019 · 7 comments
Assignees

Comments

@AMChalkie
Copy link

Strange as this may sound, I get different results when using a .fq.gz vs a .fastq file (when the .fastq is a zcat of original). I get different mappability results (0.018 ish vs the expected 85%).

Would be great if this was handled automatically and input from .fq.gz was handled correctly, or alternatively at least a warning that this might be what's happening.

Otherwise - very useful software thank you!

@hyunhwan-jeong
Copy link
Owner

Dear @AMChalkie,

The current version does not support gzipped FASTQ file, so you need to unzip the files. But the suggestion will be great for the CB^2. I will start to add the function soon.

Thank you,

Hyun-Hwan Jeong

@hyunhwan-jeong
Copy link
Owner

@AMChalkie, the current github version supports gzipped FASTQ files. I wonder you are willing to test the version and let me know if you have any problem with that.

Thank you!

Hyun-Hwan Jeong

@AMChalkie
Copy link
Author

Yes that works fine now. I notice that mappability information is not printed during the process now, which I thought was a good feature previously.

@hyunhwan-jeong
Copy link
Owner

@AMChalkie you should see the message if you set the verbose parameter as TRUE.

Thank you,

Hyun-Hwan Jeong

@hyunhwan-jeong
Copy link
Owner

@AMChalkie, Can you test on it again? The version which you tested has an incompatibility issue with Windows OS. So, I made some changes and wonder the change doesn't cause any problem.

Thank you,

Hyun-Hwan Jeong

@monovich
Copy link

monovich commented Sep 18, 2021

Was just experimenting with .fq.gz vs .fastq inputs and it looks like .fastq.gz is not accepted for some reason. I think it would make sense to add support for it as .fq.gz and .fastq.gz are both fairly common.

Edit: Started with a fresh R environment and I can't reproduce this behavior. I suspect it was an environment path issue not a CB2 issue. Sorry for the false alarm.

@hyunhwan-jeong
Copy link
Owner

hyunhwan-jeong commented Sep 20, 2021

Not a problem, and as you figured out, it has to support both - since CB2 clarifies whether it is gzipped by checking file names' suffix:

https://github.com/LiuzLab/CB2/blob/57d7fd5548c162b175a9dc6f5a57f1f73822eb0d/R/helpers.R#L69

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants