Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypeError: Argument 1 passed to Hyva\Admin\Model\TypeReflection\NamespaceMap #1

Closed
rav-redchamps opened this issue Dec 31, 2020 · 5 comments

Comments

@rav-redchamps
Copy link
Contributor

Hey @Vinai & @wigman

Thanks for putting this out.

I just installed in on Magento version 2.4.1 & while accessing admin path System > Tools > Hyvä Test, it returns below error

TypeError: Argument 1 passed to Hyva\Admin\Model\TypeReflection\NamespaceMap::__construct() must be of the type array, string given,
called in /m2/241/vendor/hyva-themes/module-magento2-admin/Model/TypeReflection/NamespaceMap.php on line 32
and defined in /m2/241/vendor/hyva-themes/module-magento2-admin/Model/TypeReflection/NamespaceMap.php:14

@Vinai
Copy link
Collaborator

Vinai commented Dec 31, 2020

Hey, thanks for trying out the module and opening the issue.
Turns out, it's an unused constructor argument that got optimized away by Rector PHP during the PHP 7.3 backport.
A new release is coming up in a little while!

@Vinai
Copy link
Collaborator

Vinai commented Dec 31, 2020

Release 1.0.2 pushed - give packagist a few monents to pick it up and you should be good to go.

@Vinai Vinai closed this as completed Dec 31, 2020
@rav-redchamps
Copy link
Contributor Author

Thanks @Vinai

But I still don't see a new release at packagist https://packagist.org/packages/hyva-themes/module-magento2-admin-test it still says dev-main. Possibly the tag hasn't been created for 1.0.2.

@rav-redchamps
Copy link
Contributor Author

Sorry my bad, the release was for main module https://packagist.org/packages/hyva-themes/module-magento2-admin. The problem is resolved now.

@Vinai
Copy link
Collaborator

Vinai commented Dec 31, 2020

Great! 👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants