Fix order email title & subject translations

[Annih]

Fixes introduced by 89ca15d added a comparison of the current locale with the order one to determine whether the content should be translated or not.

Two variables have been introduced $locale based on get_locale & $baseLocale based on WPLANG.
Sadly get_locale helper is hookable and contextual and might not return the right locale.

During my debugging session I ended up with an email title in one language and its subject in the other.

When I saw that the $baseLocale variable was present I decided to use the global WP locale of the site instead of the helper, and it fixed my issues.

Since this is an edit of your code @Jon007 what do you think?

Fix #415
Fix #416

[Jon007]

if you use the global WP locale of the site instead of the helper then the code will repeatedly unload and reload the text domain for every email string, even when the locale is already switched - this is a relatively slow and expensive operation.
Using get_locale() detects that the locale is already switched and short circuits that.
(and works fine in several languages).

Do you have any other code which is impacting locale?
Can you open this as an issue with the details of your environment and the problem you see?

Then possible pull requests should ideally be submitted as fixing issue # issue number

[Annih]

if you use the global WP locale of the site instead of the helper then the code will repeatedly unload and reload the text domain for every email string, even when the locale is already switched - this is a relatively slow and expensive operation.
Ahh yes you are right the call to switchLocale is conditioned by the locale, I thought it was used to determine whether the text should be translated or not. Thank you for your feedback.

I created #415 & #416 to report properly my issues and the investigation/debug I did.
I decided to keep only one PR since #416 is mainly triggered once #415 is fixed. I hope this is OK with you.

I updated my code to take into account your feedback, now that I have a better understanding of the code.

[Jon007]

I'll merge this and add the default cancelled order and failed order recipient as per the new_order_recipient

[Jon007]

the default recipient is the shop email address so this should not be surrounded with the translation function __( , 'woocommerce') as it will not exist in the woocommerce translation files

[frisonl]

Hi @Jon007, @Annih and of course @hyyan,

Thanks for all the amazing work. I kept having a translation issue with the emails in the heading and some parts of the mails like the topic. Even after implementing this commit.

Finnaly I found one interesting fix that solved it for me. I had the setting in my user profile on 'Site Default', which is Dutch in my case. When I changed it to English (one of the 4 languages) the emails were translated correctly.

Can you reproduce this?

[Jon007]

@frisonl I did some extra testing around the case you described and cannot reproduce, is working fine in test environment, are you sure it was not a caching or other issue.
If you have a reproducible case, please open a new issue with full details