Skip to content
This repository has been archived by the owner on Mar 17, 2022. It is now read-only.

Custom Attribute after translate changed in all languages version. #558

Open
Ihor-Youx opened this issue Jul 5, 2021 · 2 comments
Open

Comments

@Ihor-Youx
Copy link

Ihor-Youx commented Jul 5, 2021

Can you reproduce this issue on default Wordpress theme (eg Storefront)?

Yes.

Can you reproduce this issue when all other plugins are disabled except WooCommerce, Polylang and Hyyan WooCommerce Polylang Integration?

Yes

What product versions and settings are you using when this issue occurs?

  • PHP: 7.4.20
  • WordPress: 5.7.2
  • WooCommerce: 5.4.1
  • Polylang: 3.0.6
  • Hyyan WooCommerce Polylang Integration: 1.5.0
  • Browser: All

Steps to Reproduce

  1. /wp-admin/options-general.php?page=hyyan-wpi
    In Metas List uncheck Custom Product Attributes
  2. Create Product with Custom Attribute
  3. Translate this product
  4. Translate Custom Attribute

What I Expected

Custom Attribute in different languages

What Happened Instead

The translation of the attribute has also been resaved in the first language version.

@Jon007
Copy link
Contributor

Jon007 commented Dec 29, 2021

This is reproducible in version 1.5.1
syncCustomProductAttributes() is correctly exiting when _custom_product_attributes synchronisation is not enabled, seems to be carried across by other part of the code

@Jon007
Copy link
Contributor

Jon007 commented Dec 30, 2021

custom product attributes are now included in the _product_attributes meta so to prevent synchronisation Product Attributes would also have to be deselected in the Settings, WooPoly, Meta.
However this also currently stops other Product Attributes synchronising correctly

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants