Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failed to build python binding #1281

Closed
Yadro opened this issue Mar 23, 2021 · 1 comment
Closed

Failed to build python binding #1281

Yadro opened this issue Mar 23, 2021 · 1 comment

Comments

@Yadro
Copy link

Yadro commented Mar 23, 2021

I've installed dependencies sudo apt-get update && sudo apt-get install python3-dev python3-pillow -y
and tried to execute make build-python PYTHON=$(which python3), but it was failed with the following error:

led-matrix-c.cc:26:84: error: expected ‘,’ before ‘)’ token
 static_assert(sizeof(rgb_matrix::RGBMatrix::Options) == sizeof(RGBLedMatrixOptions));
                                                                                    ^
led-matrix-c.cc:26:84: error: expected string-literal before ‘)’ token
led-matrix-c.cc:27:81: error: expected ‘,’ before ‘)’ token
 static_assert(sizeof(rgb_matrix::RuntimeOptions) == sizeof(RGBLedRuntimeOptions));
                                                                                 ^
led-matrix-c.cc:27:81: error: expected string-literal before ‘)’ token

If I add a string as the second parameter, everything is fine:

- static_assert(sizeof(rgb_matrix::RGBMatrix::Options) == sizeof(RGBLedMatrixOptions));
+ static_assert(sizeof(rgb_matrix::RGBMatrix::Options) == sizeof(RGBLedMatrixOptions), "");
@hzeller
Copy link
Owner

hzeller commented Mar 23, 2021

Thanks, fixed.
older versions of C++ require the extra string.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants