Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Structures RGBMatrix:Options and RGBLedMatrixOptions members are not ordered in the same way #1517

Open
mick111 opened this issue Feb 24, 2023 · 0 comments

Comments

@mick111
Copy link
Contributor

mick111 commented Feb 24, 2023

In include/led-matrix.h and include/led-matrix-c.h, the members disable_hardware_pulsing, show_refresh_rate, and inverse_colors are not ordered in the same way:

  • Before const char *led_rgb_sequence in C++ structure RGBMatrix:Options (lines 125-137 of led-matrix.h)
  • After const char *panel_type in C structure RGBLedMatrixOptions (lines 143-149 of led-matrix-c.h)

That made this assert to fail in my fork:

static_assert(sizeof(rgb_matrix::RGBMatrix::Options) == sizeof(RGBLedMatrixOptions), "C and C++ out of sync");
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant