Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Visits are created in the backend but not displayed in the UI for Case Contacts without follow-up #10484

Closed
roxanamlendea opened this issue Sep 29, 2022 · 3 comments · Fixed by #11294
Closed

Visits are created in the backend but not displayed in the UI for Case Contacts without follow-up #10484

roxanamlendea opened this issue Sep 29, 2022 · 3 comments · Fixed by #11294
Assignees
@ChristopherRiedel @abrudanancuta
Labels
android-app Affects the Android app backend Affects the web backend change A change of an existing feature (ticket type) contacts qa-verified Issue has been tested and verified by QA vaadin-app Affects the Vaadin application
Milestone
Sprint 122 - 1.79.0

Comments

@roxanamlendea
Copy link

Bug Description

A Visit created for a Contact that has no Follow-up, is created in the backend (can be found in the db), but it is not displayed in the UI.

Steps to Reproduce

  1. Open a Case and select the Contacts tab;
  2. Import a Contact that has 'No Follow-up'.
    Here you can find an import file: sormas_import_case_contact.csv
  3. Open the Contact and select the Follow-up Visits tab;
  4. Create a New Visit;

Expected Behavior

The expected behavior needs to be discussed.

Screenshots

visits not displayed in the ui

System Details

  • Device: Windows 10
  • SORMAS version: Sormas 1.76.0-SNAPSHOT
  • Android version/Browser: Chrome
  • Server URL: local server
  • User Role: admin + national user

Additional Information
@roxanamlendea roxanamlendea added bug An error or misbehavior of an existing feature (ticket type) discuss Discussion about whether or not the issue should or can be implemented required contacts backend Affects the web backend vaadin-app Affects the Vaadin application major A functional requirement is incorrect or incomplete, ... (Severity for bugs/defects) labels Sep 29, 2022
@JaquM-HZI JaquM-HZI added this to the Sprint 121 - 1.78.0 milestone Oct 12, 2022
@markusmann-vg markusmann-vg added this to Backlog in SORMAS Team 2 - DEV - Iteration Backlog via automation Dec 14, 2022
@ChristopherRiedel ChristopherRiedel self-assigned this Dec 20, 2022
@ChristopherRiedel ChristopherRiedel moved this from Backlog to In Progress in SORMAS Team 2 - DEV - Iteration Backlog Dec 20, 2022
@ChristopherRiedel ChristopherRiedel moved this from Backlog to In Progress in SORMAS Team 4 - TEC - Iteration Backlog Dec 20, 2022
@ChristopherRiedel
Copy link
Contributor

@MateStrysewske and I agree that there is nothing wrong here. However, it is very confusing that visits outside the follow up offset (+/-30 days around the follow up period) can be created but never show up again. Therefore I will make sure that visits can no longer be created for outside the offset.

@ChristopherRiedel ChristopherRiedel added change A change of an existing feature (ticket type) android-app Affects the Android app and removed bug An error or misbehavior of an existing feature (ticket type) discuss Discussion about whether or not the issue should or can be implemented required major A functional requirement is incorrect or incomplete, ... (Severity for bugs/defects) labels Jan 4, 2023
ChristopherRiedel added a commit that referenced this issue Jan 6, 2023
@ChristopherRiedel
#10484: Added validation
386906c
@ChristopherRiedel
Copy link
Contributor

Doesn't seem to be a problem in the android-app.

@ChristopherRiedel ChristopherRiedel moved this from In Progress to Review in SORMAS Team 4 - TEC - Iteration Backlog Jan 6, 2023
@ChristopherRiedel ChristopherRiedel mentioned this issue Jan 6, 2023
Merged
ChristopherRiedel added a commit that referenced this issue Jan 10, 2023
@ChristopherRiedel
#10484: fixed review findings
5e7eda4
ChristopherRiedel added a commit that referenced this issue Jan 11, 2023
@ChristopherRiedel
#10484: Added validation (#11294)
58ddec9 
* #10484: Added validation

* #10484: fixed review findings
SORMAS Team 4 - TEC - Iteration Backlog automation moved this from In Progress to Testing Jan 11, 2023
@abrudanancuta abrudanancuta self-assigned this Jan 11, 2023
@abrudanancuta
Copy link
Contributor

Validated on test.de2 with the version: 1.79.0-SNAPSHOT (58ddec9)

@abrudanancuta abrudanancuta added the qa-verified Issue has been tested and verified by QA label Jan 11, 2023
ChristopherRiedel added a commit that referenced this issue Jan 26, 2023
@ChristopherRiedel
#10484: fixed tests
795b0e3
ChristopherRiedel added a commit that referenced this issue Jan 26, 2023
@ChristopherRiedel
#10484: fixed test
f811063
ChristopherRiedel added a commit that referenced this issue Jan 26, 2023
@ChristopherRiedel
fixed #10852 (#11354)
5921333 
* fixed #10852

* fixed review findings

* #10484: fixed tests

* #10484: fixed test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ChristopherRiedel ChristopherRiedel

@abrudanancuta abrudanancuta

Labels
android-app Affects the Android app backend Affects the web backend change A change of an existing feature (ticket type) contacts qa-verified Issue has been tested and verified by QA vaadin-app Affects the Vaadin application
Projects
None yet
Milestone
Sprint 122 - 1.79.0
Development

Successfully merging a pull request may close this issue.

#10484: Added validation SORMAS-Foundation/SORMAS-Project
5 participants
@ChristopherRiedel @markusmann-vg @JaquM-HZI @roxanamlendea @abrudanancuta