New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to JUnit5 #10793
Closed
14 tasks done
Labels
backend
Affects the web backend
change
A change of an existing feature (ticket type)
technology
Technical issues, e.g. synchronization, libraries, plugins, etc.
testing
Issues that enable or extend testing of the application
vaadin-app
Affects the Vaadin application
Milestone
Comments
MartinWahnschaffe
added
backend
Affects the web backend
vaadin-app
Affects the Vaadin application
technology
Technical issues, e.g. synchronization, libraries, plugins, etc.
testing
Issues that enable or extend testing of the application
change
A change of an existing feature (ticket type)
rest
labels
Oct 30, 2022
MartinWahnschaffe
added this to Backlog
in SORMAS Team 2 - DEV - Iteration Backlog
via automation
Nov 1, 2022
MartinWahnschaffe
moved this from Backlog
to In Progress
in SORMAS Team 2 - DEV - Iteration Backlog
Nov 1, 2022
MartinWahnschaffe
added a commit
that referenced
this issue
Nov 2, 2022
org.unit.Test -> org.junit.jupiter.api.Test org.junit.Assert.* -> org.junit.jupiter.api.Assertions.* org.junit.Assert.assertThat -> org.hamcrest.MatcherAssert.assertThat Before -> BeforeEach BeforeClass -> BeforeAll After -> AfterEach ArchUnitRunner no longer needed Test(expected=Exception) -> assertThrows Some assertions currently have string message first -> is last param instead now Use latest WireMock version for Junit5 CaseFacadeEjbTest: Extract wire mock related tests TestContainers Junit5 extension + workaround: testcontainers/testcontainers-java#970 (comment) Move tests for external surveillance functionality from CaseServiceTest and EventServiceTest into ExternalSurveillanceToolGatewayFacadeEjbTest Remove sharing logic from testArchive... test in CaseFacadeEjbTest and EventFacadeEjbTest
Merged
MartinWahnschaffe
added a commit
that referenced
this issue
Nov 2, 2022
StefanKock
moved this from In Progress
to Review
in SORMAS Team 2 - DEV - Iteration Backlog
Nov 3, 2022
MartinWahnschaffe
added a commit
that referenced
this issue
Nov 4, 2022
MartinWahnschaffe
added a commit
that referenced
this issue
Nov 4, 2022
roxanamlendea
moved this from Testing
to Done
in SORMAS Team 2 - DEV - Iteration Backlog
Nov 7, 2022
This was referenced Nov 9, 2022
Adjust the unit tests related to #10830 according to the changes and requirements from #10793
#10870
Closed
While working on #10801 I noticed that I tried |
StefanKock
added a commit
that referenced
this issue
Nov 17, 2022
StefanKock
moved this from In Progress
to Review
in SORMAS Team 2 - DEV - Iteration Backlog
Nov 17, 2022
StefanKock
added a commit
that referenced
this issue
Nov 18, 2022
StefanKock
added a commit
that referenced
this issue
Nov 18, 2022
roxanamlendea
moved this from Testing
to Done
in SORMAS Team 2 - DEV - Iteration Backlog
Nov 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backend
Affects the web backend
change
A change of an existing feature (ticket type)
technology
Technical issues, e.g. synchronization, libraries, plugins, etc.
testing
Issues that enable or extend testing of the application
vaadin-app
Affects the Vaadin application
Problem Description
JUnit5 is out since 2017 and brings the following benefits:
Furthermore JUnit5 gives us more freedom of choice and comfort related to replacing our CDI unit testing framework.
See #10074 (comment)
Proposed Change
Update to JUnit5. This means replacing imports and few clean ups.
The whole process should be done in one step.
Check whether Android app should be updated as-well or separately. -> Separately
Acceptance Criteria
Implementation Details
Additional Information
The text was updated successfully, but these errors were encountered: