Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[S2S] share request still visible on source system after case is deleted. Case still visible on source system even though case is deleted #10931

Closed
SahaLinaPrueger opened this issue Nov 16, 2022 · 4 comments
Closed

[S2S] share request still visible on source system after case is deleted. Case still visible on source system even though case is deleted #10931

SahaLinaPrueger opened this issue Nov 16, 2022 · 4 comments
Assignees
@carina29 @leventegal-she @dragosb-vg
Labels
backend Affects the web backend bug An error or misbehavior of an existing feature (ticket type) major A functional requirement is incorrect or incomplete, ... (Severity for bugs/defects) qa-verified Issue has been tested and verified by QA s2s Issues related to the SORMAS2SORMAS functionality
Milestone
Sprint 120 - 1.76.6

Comments

@SahaLinaPrueger
Copy link

Bug Description

As defined in Issue #10625:
With deleting that case/contact the share requests on both SORMAS instances should be deleted.
This has to be implemented for manual deletion and bulk deletion. For automatic deletion there is no warning message but the share requests are deleted as well.

Unfortunately the share request is still visible on the source system.

Steps to Reproduce

  1. share a case/contact with or without hand over the ownership to a target system
  2. delete the case/contact while the status of the share request is still pending
  3. go to the share directory of the source system
  4. click on the button outgoing
  5. observe if the share request you sent is still there -> share request should not be visible
  6. click on the eye button and open case7contact -> case/contact opens and is visible although case/contact is deleted

Expected Behavior

Share request should not be visible in source system after the case/contact is deleted.

Screenshots

Hotfix 1 76 6

System Details

  • Device:
  • SORMAS version: 1.76.5
  • Android version/Browser: Edge
  • Server URL: 1402 to release-de
  • User Role: admin

Additional Information
@SahaLinaPrueger SahaLinaPrueger added bug An error or misbehavior of an existing feature (ticket type) hotfix s2s Issues related to the SORMAS2SORMAS functionality labels Nov 16, 2022
@SahaLinaPrueger SahaLinaPrueger added this to the Sprint 120 - 1.76.6 milestone Nov 16, 2022
@StefanKock StefanKock added finding Something to be investigated if it is a bug, a change or another issue type and removed bug An error or misbehavior of an existing feature (ticket type) labels Nov 17, 2022
@StefanKock StefanKock added bug An error or misbehavior of an existing feature (ticket type) backend Affects the web backend major A functional requirement is incorrect or incomplete, ... (Severity for bugs/defects) and removed finding Something to be investigated if it is a bug, a change or another issue type labels Nov 17, 2022
@leventegal-she leventegal-she added this to Backlog in SORMAS Team 4 - TEC - Iteration Backlog via automation Nov 17, 2022
@leventegal-she leventegal-she moved this from Backlog to In Progress in SORMAS Team 4 - TEC - Iteration Backlog Nov 17, 2022
@leventegal-she
Copy link
Contributor

leventegal-she commented Nov 17, 2022 •
edited

@SahaLinaPrueger
Should the manually revoked(when the user clicks on the revoke button) share requests also be deleted on the source system?

leventegal-she pushed a commit that referenced this issue Nov 17, 2022
#10931 [S2S] share request still visible on source system after case …
c042f19 
…is deleted. Case still visible on source system even though case is deleted
@leventegal-she leventegal-she mentioned this issue Nov 17, 2022
Merged
@leventegal-she leventegal-she moved this from In Progress to Review in SORMAS Team 4 - TEC - Iteration Backlog Nov 17, 2022
leventegal-she added a commit that referenced this issue Nov 17, 2022
@leventegal-she
#10931 [S2S] share request still visible on source system after case …
583723d 
…is deleted. Case still visible on source system even though case is deleted (#10937)

Co-authored-by: Levente Gal <levente.gal.ext@vitagroup.ag>
SORMAS Team 4 - TEC - Iteration Backlog automation moved this from Review to Testing Nov 17, 2022
leventegal-she pushed a commit that referenced this issue Nov 17, 2022
#10931 [S2S] share request still visible on source system after case …
213f343 
…is deleted. Case still visible on source system even though case is deleted - fixed failing test
@dragosb-vg dragosb-vg self-assigned this Nov 17, 2022
SORMAS Team 4 - TEC - Iteration Backlog automation moved this from Testing to In Progress Nov 17, 2022
leventegal-she pushed a commit that referenced this issue Nov 17, 2022
#10931 [S2S] share request still visible on source system after case …
4c0c530 
…is deleted. Case still visible on source system even though case is deleted - fixed failing test
@leventegal-she leventegal-she mentioned this issue Nov 17, 2022
Merged
carina29 pushed a commit that referenced this issue Nov 17, 2022
@leventegal-she
#10931 [S2S] share request still visible on source system after case …
7830e5d 
…is deleted. Case still visible on source system even though case is deleted - fixed failing test (#10943)
@carina29
Copy link
Contributor

The fix was merged to hotfix-1.76.6 branch.

SORMAS Team 4 - TEC - Iteration Backlog automation moved this from In Progress to Testing Nov 17, 2022
@leventegal-she
Copy link
Contributor

Reopen because the last commit does not handle correctly the permanent deletion issue

SORMAS Team 4 - TEC - Iteration Backlog automation moved this from Testing to In Progress Nov 18, 2022
leventegal-she pushed a commit that referenced this issue Nov 18, 2022
#10931 [S2S] share request still visible on source system after case …
f256497 
…is deleted. Case still visible on source system even though case is deleted - fix automatic deletion when S2S revoke is needed
@leventegal-she leventegal-she mentioned this issue Nov 18, 2022
Merged
@leventegal-she leventegal-she moved this from In Progress to Review in SORMAS Team 4 - TEC - Iteration Backlog Nov 18, 2022
leventegal-she added a commit that referenced this issue Nov 18, 2022
@leventegal-she
#10931 [S2S] share request still visible on source system after case …
25249c6 
…is deleted. Case still visible on source system even though case is deleted - fix automatic deletion when S2S revoke is needed (#10955)

Co-authored-by: Levente Gal <levente.gal.ext@vitagroup.ag>
SORMAS Team 4 - TEC - Iteration Backlog automation moved this from Review to Testing Nov 18, 2022
@dragosb-vg
Copy link

Validated during a peer-testing session with @leventegal-she's on his local system on hotfix-1.76.6

The after deleting the shared case/contact/event is no longer displayed in the source system 'Share Directory -> Outgoing tab'.

@dragosb-vg dragosb-vg added the qa-verified Issue has been tested and verified by QA label Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@carina29 carina29

@leventegal-she leventegal-she

@dragosb-vg dragosb-vg

Labels
backend Affects the web backend bug An error or misbehavior of an existing feature (ticket type) major A functional requirement is incorrect or incomplete, ... (Severity for bugs/defects) qa-verified Issue has been tested and verified by QA s2s Issues related to the SORMAS2SORMAS functionality
Projects
None yet
Milestone
Sprint 120 - 1.76.6
Development

No branches or pull requests
6 participants
@StefanKock @carina29 @markusmann-vg @leventegal-she @SahaLinaPrueger @dragosb-vg