Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manual archiving of tasks [2] #4060

Closed
ophcode opened this issue Jan 18, 2021 · 8 comments · Fixed by #11139
Closed

Manual archiving of tasks [2] #4060

ophcode opened this issue Jan 18, 2021 · 8 comments · Fixed by #11139
Assignees
Labels
backend Affects the web backend feature A new feature to be developed (ticket type) qa-verified Issue has been tested and verified by QA tasks vaadin-app Affects the Vaadin application

Comments

@ophcode
Copy link

ophcode commented Jan 18, 2021

Feature Description

We as a health department (Gesundheitsamt Friedrichshain-Kreuzberg) implemented a workflow that is completely based on Sormas.
We are using "case investigation"-tasks that are marked as done when finished.
After the investigation a supervisor double-checks the investigated case and then at the end of the shift an automated script send a letter/mail to every person that has been investigated on that day.

The view of tasks marked as "done" is becoming more cluttered by the day and we would like to remove this clutter by archiving the tasks that have been double-checked and received mail.

Removing the tasks does not work (interferes with "case investigation" status), deleting the tasks is not wanted as the tasks contain important information - most importantly, the name of the person who did the investigation.

Proposed Change

Add a functionality to manually archive tasks - analogues to the "archive" button in case view.

Acceptance Criteria

Implementation Details

  • Batch processing for de-/archiving in the backend needed, not one-by-one on Task entity.

Additional Information

Possible alternatives:

  • A bulk edit archive function in the task management view - anologue to the bulk adit funcitonality in the case directory - would work as well.
  • If another, clearer, workflow is possible using existing methods in Sormas we might also switch to that if it does not add extra overhead to the investigating persons - some of them did not work on PCs before so we wantto keep their tasks as simple as possible.
@ophcode ophcode added the feature A new feature to be developed (ticket type) label Jan 18, 2021
@kwa20
Copy link

kwa20 commented Jan 18, 2021

We could add this request to issue #3430 and provide an additional archive option.

@kwa20
Copy link

kwa20 commented Aug 10, 2021

bulk option implemented with #3430. Missing: single button when editing tasks

@kwa20 kwa20 added the tasks label Aug 10, 2021
@StefanKock StefanKock added backend Affects the web backend vaadin-app Affects the Vaadin application labels Dec 5, 2022
@markusmann-vg markusmann-vg changed the title Manual archiving of tasks / bulk archiving of tasks Manual archiving of tasks / bulk archiving of tasks [2] Dec 5, 2022
@AndyBakcsy-she AndyBakcsy-she added this to Backlog in SORMAS Team 2 - DEV - Iteration Backlog via automation Dec 7, 2022
@AndyBakcsy-she AndyBakcsy-she added this to the Sprint 121 - 1.78.0 milestone Dec 7, 2022
@MateStrysewske MateStrysewske added the android-app Affects the Android app label Dec 8, 2022
@MateStrysewske MateStrysewske self-assigned this Dec 8, 2022
@MateStrysewske MateStrysewske moved this from Backlog to In Progress in SORMAS Team 2 - DEV - Iteration Backlog Dec 8, 2022
@MateStrysewske MateStrysewske removed the android-app Affects the Android app label Dec 8, 2022
@MateStrysewske MateStrysewske changed the title Manual archiving of tasks / bulk archiving of tasks [2] Manual archiving of tasks [2] Dec 8, 2022
MateStrysewske added a commit that referenced this issue Dec 8, 2022
@MateStrysewske MateStrysewske moved this from In Progress to Review in SORMAS Team 2 - DEV - Iteration Backlog Dec 8, 2022
sergiupacurariu added a commit that referenced this issue Dec 12, 2022
SORMAS Team 2 - DEV - Iteration Backlog automation moved this from Review to Testing Dec 12, 2022
@roxanamlendea roxanamlendea self-assigned this Dec 12, 2022
@StefanKock StefanKock added this to the Sprint 121 - 1.78.0 milestone Dec 13, 2022
@roxanamlendea
Copy link

Reopening because:
When the user selects 'No' in the Confirm archiving/de-archiving pop-up, the Task is automatically closed together with the pop-up. There is an inconsistency here, because, for example, when the user selects 'No' in the Confirm deletion pop-up, only the pop-up gets closed, the Task stays open.
image

@roxanamlendea roxanamlendea reopened this Dec 13, 2022
SORMAS Team 2 - DEV - Iteration Backlog automation moved this from Testing to In Progress Dec 13, 2022
@roxanamlendea
Copy link

Verified ticket on local setup using the latest version of Sormas 1.78.0-SNAPSHOT.
Note:

  1. The translations have not been yet fetched from Crowdin
  2. Currently, when archiving a Case, the Task of the archived Case is seen in the grid when 'Archived tasks' is selected, but it is not marked as archived in the db. This was the behavior since before this ticket was implemented.

@roxanamlendea roxanamlendea added the qa-verified Issue has been tested and verified by QA label Dec 15, 2022
@KristinaBorch
Copy link

KristinaBorch commented Dec 16, 2022

@roxanamlendea when setting the feature configs EDIT_ARCHIVED_ENTITIES to false, archived tasks can still be edited.

@roxanamlendea
Copy link

roxanamlendea commented Dec 16, 2022

@KristinaBorch The behavior that Tasks can be edited for archived Cases/Contacts is since #8463 was implemented. See the ticket's description and @sergiupacurariu 's comment from 24 November with the implemented behavior explanations.

@KristinaBorch
Copy link

@roxanamlendea The issue #8463 is mainly about read permission for S2S and not about read-only for archived entities. I think it is described in #8727 saying that tasks associated with archived entities should be read-only as well as archived tasks themselves.
@JaquM-HZI

@roxanamlendea
Copy link

@KristinaBorch the fact that when EDIT_ARCHIVED_ENTITIES = false, archived tasks can still be edited will be fixed when ticket #8727 will be merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Affects the web backend feature A new feature to be developed (ticket type) qa-verified Issue has been tested and verified by QA tasks vaadin-app Affects the Vaadin application
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants