Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unsaved changes prompt appearing on person form without changes being made #4920

Closed
kwa20 opened this issue Mar 27, 2021 · 8 comments
Closed
Assignees
Labels
bug An error or misbehavior of an existing feature (ticket type) persons qa-verified Issue has been tested and verified by QA vaadin-app Affects the Vaadin application

Comments

@kwa20
Copy link

kwa20 commented Mar 27, 2021

Bug Description

When navigating out of the person forms, the unsaved changes prompt appears even though no changes have been made. This only appears when geo coordinates are entered.

Steps to Reproduce

  1. Open a person form where geo coordinates are entered, otherwise, enter geo coordinates and save.
  2. Navigate out of the form

Expected Behavior

The unsaved changes prompt should only appear when changes have actually been made.

Screenshots

unsavedChangesPromptWithoutChanges

System Details

  • Device:
  • SORMAS version: 1.58.0
  • Android version/Browser: firefox
  • Server URL: test1401.sormas-oegd.de
  • User Role: admin + national user, community officer
@kwa20 kwa20 added the bug An error or misbehavior of an existing feature (ticket type) label Mar 27, 2021
@markusmann-vg markusmann-vg added this to the Sprint 102 - 1.59.0 milestone Mar 27, 2021
@markusmann-vg markusmann-vg added this to Backlog in SORMAS Team 2 - DEV - Iteration Backlog via automation Mar 27, 2021
@syntakker syntakker self-assigned this Mar 28, 2021
@syntakker syntakker moved this from Backlog to In Progress in SORMAS Team 2 - DEV - Iteration Backlog Mar 28, 2021
@syntakker
Copy link
Contributor

syntakker commented Mar 28, 2021

In a first attempt, I could not reproduce. It sounds a bit like this issue #3014 (comment)
@kwa20 what's your setting? In terms of:

  • browser language
  • SORMAS user language
  • SORMAS server locale

See also #4477

@kwa20
Copy link
Author

kwa20 commented Mar 28, 2021

@syntakker It seems like the same issue, yes.

  • browser language: german, english
  • user language: english, german
  • server locale: germany

I tried the combinations and the cause is the browser language. If it's set to german, the prompt is triggered even though no changes have been made.

@syntakker
Copy link
Contributor

syntakker commented Mar 28, 2021

I tried to reproduce with any of the combinations you listed, the bug did not manifest. I also tried on test-de.sormas.netzlink.com, same result.
However, given the number of bugs that cannot be reproduced locally or on other instances (this, #4897, #4905, #4922) might be a sign that test1401 is cursed.

Nevertheless it could be valuable to recapitulate recent steps to update the instance or find corrupt data - if there is - to be sure to not brick any production systems in the update process.

@syntakker
Copy link
Contributor

@markusmann-vg can we get the sormas.properties from test1401.sormas-oegd.de?

@kwa20
Copy link
Author

kwa20 commented Mar 29, 2021

@syntakker You can probably not reproduce it because test-de.sormas.netzlink.com does not have geo coordinate generation configured. I guess this might have an impact.

(test1401) If I enter coordinates on the case information, the prompt does not appear unexpectedly, on the person form where I can generate geo coordinates it however does.

@syntakker
Copy link
Contributor

Ok, I tried to reproduce on the person tab in a case. I'll try again in the person directory.

@kwa20
Copy link
Author

kwa20 commented Mar 29, 2021

@syntakker case person tab should also suffice for reproducing it as long as geo coordinates were generated. At least that's where it happened on my end

@MateStrysewske MateStrysewske moved this from Waiting to In Progress in SORMAS Team 2 - DEV - Iteration Backlog Mar 29, 2021
@MateStrysewske MateStrysewske self-assigned this Mar 29, 2021
MateStrysewske added a commit that referenced this issue Mar 29, 2021
SORMAS Team 2 - DEV - Iteration Backlog automation moved this from In Progress to Testing Mar 29, 2021
@AndyBakcsy-she AndyBakcsy-she added the qa-verified Issue has been tested and verified by QA label Mar 29, 2021
@AndyBakcsy-she
Copy link

Validated ticket on the latest version of 1.59.0-snapshot on local environment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An error or misbehavior of an existing feature (ticket type) persons qa-verified Issue has been tested and verified by QA vaadin-app Affects the Vaadin application
Projects
None yet
Development

No branches or pull requests

5 participants