Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable externalId in person forms when SurvNet is configured #4985

Closed
kwa20 opened this issue Apr 1, 2021 · 8 comments · Fixed by #5033 or #5076
Closed

Disable externalId in person forms when SurvNet is configured #4985

kwa20 opened this issue Apr 1, 2021 · 8 comments · Fixed by #5033 or #5076
Assignees
@ChristopherRiedel
Labels
android-app Affects the Android app change A change of an existing feature (ticket type) persons qa-verified Issue has been tested and verified by QA vaadin-app Affects the Vaadin application
Milestone
Sprint 102 - 1.59.0

Comments

@kwa20
Copy link

kwa20 commented Apr 1, 2021 •
edited

Problem Description

When the SurvNet interface is configured, the external Id is completely hidden on person forms.

Steps to Reproduce

  1. Configure the SurvNet interface
  2. Navigate to person forms
  3. check the external Id field

Proposed change

external Id should not be hidden but rather greyed out

externalIdInterface

Screenshots

externalIdInterface2

System Details

  • Device:
  • SORMAS version: 1.58.2
  • Android version/Browser: firefox
  • Server URL: test1402.sormas-oegd.de
  • User Role: admin, national user
@kwa20 kwa20 added the bug An error or misbehavior of an existing feature (ticket type) label Apr 1, 2021
@MateStrysewske
Copy link
Contributor

@kwa20 This was specifically requested by you in issue #4360

@kwa20
Copy link
Author

kwa20 commented Apr 6, 2021

@MateStrysewske I guess this was a misunderstanding then. This should then be a change request for the external Id to rather be greyed out than completely hidden.

@kwa20 kwa20 added change A change of an existing feature (ticket type) and removed bug An error or misbehavior of an existing feature (ticket type) labels Apr 6, 2021
@MateStrysewske MateStrysewske changed the title The externalId is hidden on person forms when the SurvNet interface is configured Make externalId for persons read-only when SurvNet is configured Apr 6, 2021
@MateStrysewske MateStrysewske changed the title Make externalId for persons read-only when SurvNet is configured Disable externalId in person forms when SurvNet is configured Apr 6, 2021
@MateStrysewske MateStrysewske added persons vaadin-app Affects the Vaadin application android-app Affects the Android app and removed vaadin-app Affects the Vaadin application labels Apr 6, 2021
@MateStrysewske MateStrysewske added this to Backlog in SORMAS Team 2 - DEV - Iteration Backlog via automation Apr 6, 2021
@MateStrysewske MateStrysewske added this to the Sprint 102 - 1.59.0 milestone Apr 6, 2021
@SORMAS-JanBoehme
Copy link

So this would mean the external ID can not be edited when the SurvNet interface is in use?

That may cause some problems because I know of a few departments of health that use the external ID field to store IDs from other related systems like document management software or directly generate hyperlinks to other systems from the CSV export using the external ID in the URL.

@kwa20
Copy link
Author

kwa20 commented Apr 6, 2021

@Jan-Boehme Yes, the external Id would be used to specifically refer to the unique Id in the reporting system (e.g. SurvNet). If the external Id is filled, it would be migrated to the more flexible external Token. If this field is filled as well, the Id should be added with a delimiter.

@SORMAS-JanBoehme
Copy link

I see. Thanks for the clarification.

@ChristopherRiedel ChristopherRiedel self-assigned this Apr 9, 2021
@ChristopherRiedel ChristopherRiedel moved this from Backlog to In Progress in SORMAS Team 2 - DEV - Iteration Backlog Apr 9, 2021
ChristopherRiedel added a commit that referenced this issue Apr 9, 2021
@ChristopherRiedel
#4985: Disable externalId of person if externalSurveillanceTool is en…
101dc9c 
…abled
@ChristopherRiedel ChristopherRiedel mentioned this issue Apr 9, 2021
Merged
SORMAS Team 2 - DEV - Iteration Backlog automation moved this from In Progress to Testing Apr 9, 2021
alexcaruntu-vita pushed a commit that referenced this issue Apr 9, 2021
@ChristopherRiedel
#4985: Disable externalId of person if externalSurveillanceTool is en…
4cbdaff 
…abled (#5033)

Co-authored-by: Christopher Riedel <42139870+ChristopherRiedelSymeda@users.noreply.github.com>
@AndyBakcsy-she AndyBakcsy-she added the qa-verified Issue has been tested and verified by QA label Apr 12, 2021
@AndyBakcsy-she
Copy link

Validated ticket on the latest version of SORMAS Version: 1.59.0-SNAPSHOT on test-de1.sormas.netzlink.com environment

@kwa20
Copy link
Author

kwa20 commented Apr 12, 2021

@AndyBakcsy-she I also tested on test-de1 but on my end it looks like this:
externalIdPerson2
The title is there but the field is still missing.

Expected would be the same as seen on the case tab:
externalIdPerson

@MateStrysewske
Copy link
Contributor

@ChristopherRiedel I suspect you set the field to read-only. The correct approach (as stated both in the issue title and description) is to set it to disabled.

SORMAS Team 2 - DEV - Iteration Backlog automation moved this from Done to In Progress Apr 13, 2021
@ChristopherRiedel ChristopherRiedel moved this from In Progress to Waiting in SORMAS Team 2 - DEV - Iteration Backlog Apr 13, 2021
@ChristopherRiedel ChristopherRiedel moved this from Waiting to In Progress in SORMAS Team 2 - DEV - Iteration Backlog Apr 14, 2021
@AndyBakcsy-she AndyBakcsy-she removed the qa-verified Issue has been tested and verified by QA label Apr 14, 2021
ChristopherRiedel added a commit that referenced this issue Apr 14, 2021
@ChristopherRiedel
#4985: Disable external id field
7d7ed39
@ChristopherRiedel ChristopherRiedel mentioned this issue Apr 14, 2021
Merged
SORMAS Team 2 - DEV - Iteration Backlog automation moved this from Review to Testing Apr 14, 2021
MateStrysewske pushed a commit that referenced this issue Apr 14, 2021
@ChristopherRiedel
Change 4985 disable external id in person form (#5076)
43291ea 
* #4985: Disable externalId of person if externalSurveillanceTool is enabled

* #4985: Disable external id field

Co-authored-by: Christopher Riedel <42139870+ChristopherRiedelSymeda@users.noreply.github.com>
@AndyBakcsy-she AndyBakcsy-she added the qa-verified Issue has been tested and verified by QA label Apr 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ChristopherRiedel ChristopherRiedel

Labels
android-app Affects the Android app change A change of an existing feature (ticket type) persons qa-verified Issue has been tested and verified by QA vaadin-app Affects the Vaadin application
Projects
None yet
Milestone
Sprint 102 - 1.59.0
5 participants
@SORMAS-JanBoehme @MateStrysewske @ChristopherRiedel @kwa20 @AndyBakcsy-she