Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting missing geo-coordinates runs into an error #5992

Closed
marko-arn opened this issue Jun 29, 2021 · 8 comments · Fixed by #5998
Closed

Setting missing geo-coordinates runs into an error #5992

marko-arn opened this issue Jun 29, 2021 · 8 comments · Fixed by #5998
Assignees
Labels
backend Affects the web backend bug An error or misbehavior of an existing feature (ticket type) minor Text issues, layouting or cosmetic problems, ... (Severity for bugs/defects) persons qa-verified Issue has been tested and verified by QA

Comments

@marko-arn
Copy link

Bug Description

We were trying to set the missing geo-coordinates several time, but it always run into an error/time-out after approx. 15 sec. We don't know were the error comes from as the error message is very unspecific.

We are having 3713 cases without coordinates, for the contacts and ep there is no filter to show it. After using the function 10 times the number of cases hasn't changed, so there are not set any geo-coordinate.

Maybe there are:

  • addresses not compatible
  • errors in addresses

But I think the tool should just skip this errors and not stop itself.

Maybe @DavidBaldsiefen can help?

Steps to Reproduce

  1. open person directory
  2. use the set missing geo-coordinates

Screenshots

image
image

System Details

  • Device:
  • SORMAS version:
  • Android version/Browser:
  • Server URL:
  • User Role:

Additional Information

@marko-arn marko-arn added the bug An error or misbehavior of an existing feature (ticket type) label Jun 29, 2021
@DavidBaldsiefen DavidBaldsiefen self-assigned this Jun 29, 2021
@DavidBaldsiefen DavidBaldsiefen added this to Backlog in SORMAS Team 2 - DEV - Iteration Backlog via automation Jun 29, 2021
@DavidBaldsiefen DavidBaldsiefen moved this from Backlog to In Progress in SORMAS Team 2 - DEV - Iteration Backlog Jun 29, 2021
@marko-arn
Copy link
Author

Is missed to mention, that it occurs in 1.59.2 on our own instance at ITZ Bund. As I don't have access to an test-server with working geo-coordinate-setting I cannot test it anywhere else.

@DavidBaldsiefen
Copy link
Contributor

@Marko-ilmkreis Do you have access to serverlogs?
It could be possible that the server runs into a timeout when trying to evaluate illegal addresses. This exception used to be caught but I can see now that that exceptionHandler was removed, probably by accident

@marko-arn
Copy link
Author

marko-arn commented Jun 29, 2021

@DavidBaldsiefen Unfortunately not, but I will request the server-logs from Netzlink

@DavidBaldsiefen DavidBaldsiefen added the backend Affects the web backend label Jun 29, 2021
@DavidBaldsiefen
Copy link
Contributor

Does individually setting coordinates using the needle-button still work?

@marko-arn
Copy link
Author

Yes, that is working fine without any problems.

@MateStrysewske MateStrysewske moved this from In Progress to Waiting in SORMAS Team 2 - DEV - Iteration Backlog Jun 29, 2021
@MateStrysewske MateStrysewske added general Not directly concerned with any particular functional section of the application persons and removed general Not directly concerned with any particular functional section of the application labels Jun 29, 2021
@MateStrysewske MateStrysewske added this to the Sprint 105 - 1.62.0 milestone Jun 29, 2021
@DavidBaldsiefen
Copy link
Contributor

I tried and it seems to be a uncaught timeout. I already have a fix ready, however if there are a lot of "illegal addresses", each timeout will add another ~10 seconds to the process, so the entire process might take quite some time

@marko-arn
Copy link
Author

@DavidBaldsiefen That is no problem. We can make the first run outside the working hours and so the system has all the time to finish

@RazvanHodisan
Copy link

Verified on test-de, Version: 1.61.0-SNAPSHOT

@RazvanHodisan RazvanHodisan added the qa-verified Issue has been tested and verified by QA label Jun 29, 2021
@RazvanHodisan RazvanHodisan self-assigned this Jun 29, 2021
@StefanKock StefanKock added the minor Text issues, layouting or cosmetic problems, ... (Severity for bugs/defects) label Jul 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Affects the web backend bug An error or misbehavior of an existing feature (ticket type) minor Text issues, layouting or cosmetic problems, ... (Severity for bugs/defects) persons qa-verified Issue has been tested and verified by QA
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants