Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a server property that allows to reduce the follow-up period below the usual threshold [2] #6862

Closed
SORMAS-JanBoehme opened this issue Oct 1, 2021 · 2 comments · Fixed by #7526
Assignees
Labels
backend Affects the web backend cases change A change of an existing feature (ticket type) configuration contacts qa-verified Issue has been tested and verified by QA vaadin-app Affects the Vaadin application

Comments

@SORMAS-JanBoehme
Copy link

SORMAS-JanBoehme commented Oct 1, 2021

Please note that the development specifications differ from the original specification of this issue.

Feature Description

Make "Overwrite follow-up until date" remove the restriction for the minimum length of the follow up period.

Problem Description

At the moment the local health department in germany do not always use a 14 day quarantine period. for example if someone can provide a negative test result after five days or the quarantine itself is only scheduled for less than 14 days.

As the people entering the data and setting the quarantine dates are most of the time not the ones doing the follow-up calls they don't really know if the person scheduled for a call really needs to be called or if that person already finished quarantine.
Due to this reason the people setting the quarantine dates tried to set the follow-up period to a shorter time than 14 days but even when using the "override follow-up until date" checkbox the field "follow-up until" does not allow for a persod shorter than the one configured for the disease server-side.

Proposed Change

If the user activates the checkbox "override follow-up until date" the restriction on the length of the follow-up period should be deactivated. As the user actively clicks on the checkbox it is safe to assume that setting the period to a shorter time than it should theoretically be is an active decision by the user and not an error.

If the user sets a length that is shorter than the server config states the filed should become blue and a mouse over information should appear with the following text:
"The follow up period is shorter than expected for the selected disease."

Checks for dates in the past or invalid dates should stay in place.

Possible Alternatives

Additional Information

2021-10-01_14h49_13

Development Specifications

  • Add a boolean feature type property called ALLOW_FREE_FOLLOW_UP_OVERWRITE and add it to the CONTACT_TRACING and CASE_FOLLOWUP features; default false
  • When the new property == true, for the respective section (contact/case), when the user overwrites the follow-up period and sets a date that is before the default minimum follow-up date, instead of showing a hard error and preventing the user from saving the form, show a soft error (i.e. the light blue field outline and exclamation mark in the web app that is e.g. displayed when setting a temperature in the symptoms tab and not specifying the fever field) and change the text that is displayed to "The follow-up until date should at least be on the day the standard follow-up duration for the disease would end."
@SORMAS-JanBoehme SORMAS-JanBoehme added the change A change of an existing feature (ticket type) label Oct 1, 2021
@SORMAS-JanBoehme
Copy link
Author

@kwa20 @JaquM What's your opinion on this change request from the german helath departments?

@kwa20
Copy link

kwa20 commented Oct 1, 2021

@Jan-Boehme From an epidemiological perspective, we need to encourage the follow-up of cases and contacts for a time after which it is safe to say whether a contact person will be infected or a case person ideally recovered or else. This is based on the incubation period and should stay independent of the quarantine period which is often based on the law and therefore might diverge.

However, I'd suggest to not just change this logic but rather to introduce a property called freelyoverwritefollowup which

  • if it is set to TRUE, allows to freely overwrite the follow-up but keeps the blue mouseover tip and
  • if it is set to FALSE, keeps the hard validation as it is implemented now

default should be FALSE

@markusmann-vg markusmann-vg added this to the Sprint 109 - 1.66 milestone Oct 14, 2021
@MateStrysewske MateStrysewske changed the title "Overwrite follow-up until date" should remove restriction on the follow-up-until field Add a server property that allows to reduce the follow-up period below the usual threshold Oct 18, 2021
@MateStrysewske MateStrysewske added cases configuration contacts backend Affects the web backend vaadin-app Affects the Vaadin application labels Oct 18, 2021
@MateStrysewske MateStrysewske added the needs-refinement Refinement or further specification required label Oct 20, 2021
@StefanKock StefanKock removed this from the Sprint 108 - 1.65.0 milestone Oct 20, 2021
@markusmann-vg markusmann-vg added this to the Sprint 109 - 1.66.0 milestone Nov 3, 2021
@StefanKock StefanKock removed this from the Sprint 109 - 1.66.0 milestone Nov 3, 2021
@markusmann-vg markusmann-vg added this to the Sprint 110 - 1.67.0 milestone Nov 25, 2021
@MateStrysewske MateStrysewske added android-app Affects the Android app and removed needs-refinement Refinement or further specification required labels Dec 2, 2021
@StefanKock StefanKock changed the title Add a server property that allows to reduce the follow-up period below the usual threshold Add a server property that allows to reduce the follow-up period below the usual threshold [2] Dec 9, 2021
@StefanKock StefanKock added this to Backlog in SORMAS Team 2 - DEV - Iteration Backlog via automation Dec 9, 2021
@BarnaBartha BarnaBartha self-assigned this Dec 14, 2021
@BarnaBartha BarnaBartha moved this from Backlog to In Progress in SORMAS Team 2 - DEV - Iteration Backlog Dec 14, 2021
@MateStrysewske MateStrysewske removed the android-app Affects the Android app label Dec 15, 2021
@BarnaBartha BarnaBartha moved this from In Progress to Review in SORMAS Team 2 - DEV - Iteration Backlog Dec 15, 2021
@MateStrysewske MateStrysewske self-assigned this Dec 16, 2021
MateStrysewske added a commit that referenced this issue Dec 17, 2021
SORMAS Team 2 - DEV - Iteration Backlog automation moved this from Review to Testing Dec 17, 2021
MateStrysewske added a commit that referenced this issue Dec 17, 2021
#7526)

* #6062 - add feature type property to add soft/warning validation for follow up until field

* #6862 - Don't automatically overwrite follow-up until date when new property is enabled

* #6862 - Fixed merge conflicts

Co-authored-by: Maté Strysewske <mate.strysewske@vitagroup.ag>
@AndyBakcsy-she AndyBakcsy-she self-assigned this Dec 20, 2021
@AndyBakcsy-she AndyBakcsy-she added the qa-verified Issue has been tested and verified by QA label Dec 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Affects the web backend cases change A change of an existing feature (ticket type) configuration contacts qa-verified Issue has been tested and verified by QA vaadin-app Affects the Vaadin application
Projects
None yet
7 participants