Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make tile server used for map configurable [2] #7792

Closed
2 tasks
MartinWahnschaffe opened this issue Jan 27, 2022 · 2 comments · Fixed by #7963
Closed
2 tasks

Make tile server used for map configurable [2] #7792

MartinWahnschaffe opened this issue Jan 27, 2022 · 2 comments · Fixed by #7963
Assignees
@leventegal-she
Labels
backend Affects the web backend change A change of an existing feature (ticket type) configuration qa-verified Issue has been tested and verified by QA vaadin-app Affects the Vaadin application
Milestone
Sprint 112 - 1.69.0

Comments

@MartinWahnschaffe
Copy link
Contributor

MartinWahnschaffe commented Jan 27, 2022 •
edited by markusmann-vg

Feature Description

We are using leaflet js to display maps in SORMAS. The used tile server url is currently hard coded in the leaflet-connector javascript.

Problem Description

This approach does not allow to use different tile servers or to put a proxy in between.

Proposed Change

  • Add the configuration to sormas.properties
  • Extend the leaflet map component to use the configured tile server

Possible Alternatives

Additional Information

Default the one that is currently hardcoded.
If there is no property defined, we don't show the tiles
Validate what happens if there is sth. defined which does not work (404)

Examples:
http://leaflet-extras.github.io/leaflet-providers/preview/index.html
@MartinWahnschaffe MartinWahnschaffe added backend Affects the web backend vaadin-app Affects the Vaadin application change A change of an existing feature (ticket type) configuration labels Jan 27, 2022
@vidi42
Copy link
Contributor

vidi42 commented Jan 31, 2022 •
edited

Tile server hardcoded in sormas-ui/src/main/webapp/VAADIN/map/leaflet-connector.js

@markusmann-vg markusmann-vg changed the title Make tile server used for map configurable Make tile server used for map configurable [2] Jan 31, 2022
@leventegal-she leventegal-she added this to Backlog in SORMAS Team 4 - TEC - Iteration Backlog via automation Feb 10, 2022
@leventegal-she leventegal-she moved this from Backlog to In Progress in SORMAS Team 4 - TEC - Iteration Backlog Feb 10, 2022
@leventegal-she leventegal-she self-assigned this Feb 10, 2022
leventegal-she pushed a commit that referenced this issue Feb 11, 2022
#7792 Make tile server used for map configurable
51722c2
@leventegal-she leventegal-she mentioned this issue Feb 11, 2022
Merged
@leventegal-she leventegal-she moved this from In Progress to Review in SORMAS Team 4 - TEC - Iteration Backlog Feb 11, 2022
leventegal-she pushed a commit that referenced this issue Feb 17, 2022
#7792 Make tile server used for map configurable - remove unnecessary…
db65422 
… comment
SORMAS Team 4 - TEC - Iteration Backlog automation moved this from Review to Testing Feb 17, 2022
leventegal-she added a commit that referenced this issue Feb 17, 2022
@leventegal-she
#7792 Make tile server used for map configurable (#7963)
ee97977
@StefanKock StefanKock added this to the Sprint 112 - 1.69.0 milestone Feb 21, 2022
@AndyBakcsy-she
Copy link

Validated ticket on the latest version of Sormas 1.69.0-snapshot on local environment

@AndyBakcsy-she AndyBakcsy-she added the qa-verified Issue has been tested and verified by QA label Feb 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@leventegal-she leventegal-she

Labels
backend Affects the web backend change A change of an existing feature (ticket type) configuration qa-verified Issue has been tested and verified by QA vaadin-app Affects the Vaadin application
Projects
None yet
Milestone
Sprint 112 - 1.69.0
Development

Successfully merging a pull request may close this issue.

#7792 Make tile server used for map configurable SORMAS-Foundation/SORMAS-Project
5 participants
@vidi42 @MartinWahnschaffe @StefanKock @leventegal-she @AndyBakcsy-she