Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Measures are displayed in action title column in action view #9012

Closed
kwa20 opened this issue Apr 29, 2022 · 5 comments · Fixed by #9085
Closed

Measures are displayed in action title column in action view #9012

kwa20 opened this issue Apr 29, 2022 · 5 comments · Fixed by #9085
Assignees
Labels
bug An error or misbehavior of an existing feature (ticket type) events major A functional requirement is incorrect or incomplete, ... (Severity for bugs/defects) qa-verified Issue has been tested and verified by QA vaadin-app Affects the Vaadin application

Comments

@kwa20
Copy link

kwa20 commented Apr 29, 2022

Bug Description

Instead of the action title, the measures of an action are displayed in the action title column in the action view.

Steps to Reproduce

  1. Open or create an event
  2. Create a new action and fill measures and title fields
  3. Check the respective action and the action title column

Expected Behavior

action title column should display the title

Screenshots

actionTitleDirectory

actionTitleDirectory2

System Details

  • Device:
  • SORMAS version: 1.70.3 / 1.71-SNAPSHOT
  • Android version/Browser: chrome
  • Server URL: test1401.sormas-oegd.de / test-de2.sormas.netzlink.com
  • User Role: admin, national user

Additional Information

@kwa20 kwa20 added bug An error or misbehavior of an existing feature (ticket type) events vaadin-app Affects the Vaadin application labels Apr 29, 2022
@MateStrysewske MateStrysewske added the major A functional requirement is incorrect or incomplete, ... (Severity for bugs/defects) label Apr 29, 2022
@markusmann-vg markusmann-vg added this to Backlog in SORMAS Team 2 - DEV - Iteration Backlog via automation May 2, 2022
@carina29 carina29 self-assigned this May 4, 2022
@carina29 carina29 added this to Backlog in SORMAS Team 4 - TEC - Iteration Backlog via automation May 4, 2022
@carina29 carina29 moved this from Backlog to In Progress in SORMAS Team 4 - TEC - Iteration Backlog May 5, 2022
@carina29
Copy link
Contributor

carina29 commented May 5, 2022

Hello @kwa20 !
I have investigated the bug. The problem is related to one of the comments from this ticket: #4013.
A check was introduced based on one of the comments. When the measure is selected and if the selected measure is something different than OTHER, the actionMeasure will be displayed instead of the title.
Since you've said in 4013 that the title should stay, because it's non-compulsory I will remove the check related to the measure.

Is that ok for you? :)

Thank you very much!

@mario-kuehne
Copy link
Contributor

mario-kuehne commented May 9, 2022

Bug reproduction

Reproduced issue with

Bugfix test
Will be tested locally because bugfix is not yet deployed on test instances.

Succesfully tested locally with Version: 1.72.0-SNAPSHOT (1ad8b08) that title of Action will be shown in column 'Action Title' in 'Action Directory' with user that has roles Admin & National User

9012-edit-event-action

9012-action-directory-table

Measure Title 'Action Title' column (Action Directory) Remark (test scenario)
Active follow-up of contact persons Measure filled, Title empty
Only Title Only Title Measure empty, Title filled
Measure empty, Title empty
Closure of facility Measure + Title Measure + Title Measure filled, Title filled
Other Measure (other) + Title Measure (other) + Title Measure filled, Title filled

@kwa20 do the test scenarios / equivalance classes shown for 'measure' / 'title' combinations fulfill the requirements?

@mario-kuehne mario-kuehne added the qa-verified Issue has been tested and verified by QA label May 9, 2022
@carina29
Copy link
Contributor

carina29 commented May 9, 2022

I have talked with @mario-kuehne that right now with this bugfix the measurements checks were removed and the title is shown in every case.
If we want to have different scenarios based on the selected measurements or given title, I would suggest to open another ticket since in this one it was not requested to handle the combinations mentioned in the above table.
The only requirement was related to the display of the title instead of the measurement.

@kwa20
Copy link
Author

kwa20 commented May 9, 2022

@carina29 @mario-kuehne Looks fine to me. I guess the problem here was also related to the hierarchical direction of fallback from measures to title. The fix here should be fine and more intuitive in regards to the column header.

@AliciaRaber
Copy link

Test performed on test1401.sormas-oegd.de V1.72.1

Created action:
image

Overview in action list:
image

Action title no is displayed according to entry in action.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An error or misbehavior of an existing feature (ticket type) events major A functional requirement is incorrect or incomplete, ... (Severity for bugs/defects) qa-verified Issue has been tested and verified by QA vaadin-app Affects the Vaadin application
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants