Feature/redbox 74 trigger embedding post ingest #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gecBurton
force-pushed
the
feature/REDBOX-74-trigger-embedding-post-ingest
branch
from
f33e4ef
to
b49615d
Compare
gecBurton
commented
Mar 14, 2024
gecBurton
commented
Mar 14, 2024
| items = self.file_destination.write_items(chunks) | ||
| logging.info(f"written {len(items)} chunks to elasticsearch") | ||
|
|
||
| for chunk in chunks: |
There was a problem hiding this comment.
this is the key change
lmwilkigov
approved these changes
Mar 14, 2024
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
As a User I want the Ingest-app to add messages to the
embed-queueonce it has finished chunking so that theembedapp knows it should embed the chunksChanges proposed in this pull request
I have added code to publish ingested chunks to the embed queue
Guidance to review
Note that the rabbitmq tests are very flakey in so much that there is no fixture to ensure that the messages created in test do not overlap with those in your local state (obv not a problem in CI). this is probably the answer https://pypi.org/project/pytest-rabbitmq/ but is out of scope
Relevant links
https://technologyprogramme.atlassian.net/browse/REDBOX-74
Things to check