Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add document upload page #109

Merged
merged 2 commits into from
Mar 14, 2024
Merged

Add document upload page #109

merged 2 commits into from
Mar 14, 2024

Conversation

KevinEtchells
Copy link
Contributor

This is adding a basic document upload page, visible at /upload. I've made a start on views.py. I've also updated base.html for the elements shared across pages.

image

How to test

  • Check that the page looks okay
  • After uploading, the document name should be displayed in the terminal

Things not covered

  • I'm aware of the missing logo in the footer. This can be a separate job.
  • The cancel button/link is currently broken, but I'll be looking at that page next!

Jira link

https://technologyprogramme.atlassian.net/jira/software/projects/REDBOX/boards/409?selectedIssue=REDBOX-71


@import "django_app/frontend/node_modules/govuk-frontend/dist/govuk/all";
@import "../node_modules/govuk-frontend/dist/govuk/all";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is causing tests to fail - the previous version is safer

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I didn't mean to change that - I think that's a mistake when resolving conflicts. I'll sort now - thanks!

Copy link
Contributor

@rachaelcodes rachaelcodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a good start :)

@KevinEtchells KevinEtchells merged commit c3ff5dc into main Mar 14, 2024
5 checks passed
@KevinEtchells KevinEtchells deleted the feature/upload-page branch March 14, 2024 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants