Feature/get file chunks #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gecBurton
force-pushed
the
feature/simply-model-api
branch
from
4e78a72
to
c780c1e
Compare
lmwilkigov
requested changes
Mar 26, 2024
redbox/storage/elasticsearch.py
Outdated
| res = [ | ||
| item["_source"] | ||
| for item in self.es_client.search( | ||
| index=target_index, query={"bool": {"filter": [{"term": {"parent_file_uuid": str(parent_file_uuid)}}]}} |
There was a problem hiding this comment.
We should use the scan functionality shown further up to ensure proper retrieval of large results.
There was a problem hiding this comment.
that would explain why my test didn't pass!
lmwilkigov
approved these changes
Mar 27, 2024
lmwilkigov
approved these changes
Mar 27, 2024
gecBurton
force-pushed
the
feature/get-file-chunks
branch
from
0100d16
to
32484fb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
As an User I want a way to retrieve Chunks associated with a File so that I can see that the chunks:
Changes proposed in this pull request
A new endpoint
/file/{file_uuid}/chunkshas been added that returnslist[Chunk]Guidance to review
Relevant links
Things to check