REDBOX-71 file upload #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rachaelcodes
commented
Mar 27, 2024
rachaelcodes
commented
Mar 27, 2024
rachaelcodes
commented
Mar 27, 2024
gecBurton
reviewed
Mar 28, 2024
rachaelcodes
force-pushed
the
feature/REDBOX-71-file-upload-page
branch
from
ae993a6
to
2ad2a11
Compare
rachaelcodes
force-pushed
the
feature/REDBOX-71-file-upload-page
branch
from
2ad2a11
to
79fc9e9
Compare
rachaelcodes
force-pushed
the
feature/REDBOX-71-file-upload-page
branch
from
4bc61fb
to
2d93d83
Compare
rachaelcodes
force-pushed
the
feature/REDBOX-71-file-upload-page
branch
from
df34295
to
d0f6653
Compare
rachaelcodes
force-pushed
the
feature/REDBOX-71-file-upload-page
branch
from
d0f6653
to
0ecee54
Compare
gecBurton
reviewed
Apr 4, 2024
gecBurton
reviewed
Apr 4, 2024
no, I'll take a look |
rachaelcodes
force-pushed
the
feature/REDBOX-71-file-upload-page
branch
from
1bfb55b
to
358bc54
Compare
rachaelcodes
force-pushed
the
feature/REDBOX-71-file-upload-page
branch
from
cb0bac7
to
e11d15c
Compare
rachaelcodes
force-pushed
the
feature/REDBOX-71-file-upload-page
branch
from
e11d15c
to
024b1af
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Since starting this ticket, we've discussed moving the S3 upload from the
core-apito the Django frontend, and instead passing the file by reference.Changes proposed in this pull request
Links the Django file upload page to the core-api.
Moves the S3 upload and signed URL collection from the core-api to the django application.
Guidance to review
We're still in the process of updating the architecture, so the key question is: is the separation of concerns sensible?
Relevant links
Things to check