Skip to content
This repository has been archived by the owner on Apr 26, 2018. It is now read-only.

0.2.3 - methods aren't injected if typeof module.exports is 'function' #16

Closed
tran2 opened this issue Sep 9, 2015 · 3 comments
Closed
Labels

Comments

@tran2
Copy link

tran2 commented Sep 9, 2015

In 0.2.3, there's a check if typeof module.exports === 'object' before injecting.
In some of my codes, typeof module === 'object' but typeof module.exports === 'function'
so __get__ and __set__ never gets injected

@loudwinston
Copy link

I've also encountered this issue. This changes breaks rewireify for anyone exporting a React component in a module, since React.createClass returns a function.

My team has reverted to 0.2.2 for now until this issue is resolved.

@i-like-robots
Copy link
Owner

Thanks for reporting this, a fix is imminent

@i-like-robots
Copy link
Owner

Fixed in 059be2b

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants