Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typo case miss(mix)matching in modue name #271

Closed
punkratz312 opened this issue Apr 16, 2023 · 7 comments
Closed

typo case miss(mix)matching in modue name #271

punkratz312 opened this issue Apr 16, 2023 · 7 comments

Comments

@punkratz312
Copy link

punkratz312 commented Apr 16, 2023

i18next-browser-languagedetector
i18next-browser-language-detector

image

snake-case is desired case and most common in all projects almost.

image

image

its kind of easy to migrate: simply deprecate this repo and switch to a new c&p version with a new name.

@adrai
Copy link
Member

adrai commented Apr 16, 2023

Why is this a problem after so many years?

@jamuhl
Copy link
Member

jamuhl commented Apr 16, 2023

it's anyway i18next-specific implementation-pluginType nothing todo with casing

@jamuhl jamuhl closed this as completed Apr 16, 2023
@punkratz312
Copy link
Author

punkratz312 commented Apr 17, 2023

image

its called
"i18next-http-backend": "2.0.2",
and not
"i18next-httpbackend": "2.0.2",
or
"i18next-httpBackend": "2.0.2",

don´t be lazy around here whats up.

i18next-browser-languageDetector is dangling fix it to
i18next-browser-language-detector

to much better to read and understand and these are 2 seperate words as you intend in cour camelCasing 🐪

so please fix it up and use what the whole internet preffesed snake-case

@adrai im see it only right now and im the qa guy in our team. i see what other people dont (want to see)

@jamuhl
Copy link
Member

jamuhl commented Apr 17, 2023

i18next-http-backend

-> i18next
-> http (using http, request, fetch, ...)
-> backend (is the plugin type)

so naming makes sense

i18next-http-backend
i18next-redis-backend
i18next-mongodb-backend
i18next-fs-backend
i18next-localstorage-backend
...

@jamuhl
Copy link
Member

jamuhl commented Apr 17, 2023

same also for:

i18next-{type}-postProcessor

@jamuhl
Copy link
Member

jamuhl commented Apr 17, 2023

beside that JS uses camelCase mostly...not snake_case

@jamuhl
Copy link
Member

jamuhl commented Apr 17, 2023

its kind of easy to migrate: simply deprecate this repo and switch to a new c&p version with a new name

would put a high burden on all other devs having to update their dependencies to new module...(which most won't even notice -> as it's not a automatic ncu -u)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants