Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

copy typescript type definition file to the dist folder after build #695

Merged
merged 1 commit into from Jan 17, 2023

Conversation

gynekolog
Copy link
Contributor

Why am I submitting this PR

This resolves missing typescript definition file in the production build.

Does it fix an existing ticket?

Yes #694

@gynekolog
Copy link
Contributor Author

The quickest way is to copy the index.d.ts file to the dist folder.

It will be better generate types from the source files. I tried that with the command

npx -p typescript tsc src/**/*.js --declaration --allowJs --emitDeclarationOnly --outDir dist

but the process failed because the vue types are missing.
I could try it later but for now, copying the file currently fixes the issue.

@gynekolog
Copy link
Contributor Author

Hello @karellm, is there any action what can I do to have the pull request merged?

@karellm karellm merged commit 080f377 into i18next:master Jan 17, 2023
@karellm
Copy link
Member

karellm commented Jan 17, 2023

Thanks. This is in 7.5.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants