New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

False ns type error when parsing <Trans ns="..."> #183

Merged

cheton merged 1 commit into i18next:master from sgwanlee:master

Oct 12, 2021

Contributor

sgwanlee commented Apr 21, 2020

Hi, I've got false error when parsing Trans with ns attributre.

I think it should be attr.ns for testing the type not options.ns


          fix false ns type error

9a31d76

mxsxs2 commented Aug 18, 2020

I think @sgwanlee is right. The check always returns undefined for typeof options.ns but typeof attr.ns returns string

cheton approved these changes

View reviewed changes

cheton merged commit 6a6bf79 into i18next:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment