Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

importing DefaultNamespace even though it's not exported #2060

Closed
maks-io opened this issue Dec 15, 2022 · 3 comments
Closed

importing DefaultNamespace even though it's not exported #2060

maks-io opened this issue Dec 15, 2022 · 3 comments

Comments

@maks-io
Copy link
Contributor

maks-io commented Dec 15, 2022

Hi,

i saw that you're importing DefaultNamespace in https://github.com/i18next/next-i18next/blob/master/src/types.ts from react-i18next for the sake of re-exporting it, but it is actually not being exported from there: https://github.com/i18next/react-i18next/blob/v12.1.1/index.d.ts

I could create a PR for it, question is in which direction you guys wanna go.

Or maybe I'm missing something in general, but it seems off to me.

@adrai
Copy link
Member

adrai commented Dec 15, 2022

Seems you're right...
a PR is very welcome ;-)

@maks-io
Copy link
Contributor Author

maks-io commented Dec 15, 2022

Seems you're right... a PR is very welcome ;-)

Sure thing :)
#2061

@adrai
Copy link
Member

adrai commented Dec 15, 2022

should be fixed with v13.0.2

@adrai adrai closed this as completed Dec 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants