Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

React 15.2 errors #166

Closed
sorahn opened this issue Jul 11, 2016 · 2 comments
Closed

React 15.2 errors #166

sorahn opened this issue Jul 11, 2016 · 2 comments

Comments

@sorahn
Copy link

sorahn commented Jul 11, 2016 •
edited

There is new error reporting in react 15.2 that complains about leaking attributes into the DOM.

Looks like there are a couple in here.

https://www.dropbox.com/s/cxnnffy7cw0ahtk/Screenshot%202016-07-11%2015.01.24.png?dl=0

In that screenshot 'currentYear' and 'domain' are our attributes getting passed into <Interpolate />
@jamuhl
Copy link
Member

jamuhl commented Jul 12, 2016

seems we should stop passing the props to the component in interpolate...will look into this asap and publish a fix. thanks for reporting.

@jamuhl
Copy link
Member

jamuhl commented Jul 12, 2016

should be fixed in react-i18next@1.6.2

@jamuhl jamuhl closed this as completed Jul 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sorahn @jamuhl