Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should i18next be a peerDependency? #217

Closed
tleunen opened this issue Dec 13, 2016 · 2 comments
Closed

Should i18next be a peerDependency? #217

tleunen opened this issue Dec 13, 2016 · 2 comments

Comments

@tleunen
Copy link

tleunen commented Dec 13, 2016

When building an app with react-i18next, the file i18n has a reference on the module i18next. So it means the user project should have i18next has a direct dependency.

So i18next should be listed as a peerDependency so we know exactly which version we can install

@jamuhl
Copy link
Member

jamuhl commented Dec 13, 2016

can add that i18next >= 2.x.x for next version..no problem

@jamuhl
Copy link
Member

jamuhl commented Dec 16, 2016

upcoming version will include in package.json:

  "peerDependencies": {
    "i18next": ">= 2.0.0",
  },

@jamuhl jamuhl closed this as completed Dec 16, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants